feat: configurable Prometheus remote write timeout #4
Conversation
Makes it possible to change timeout of http client which does Prometheus remote write via: - `write_timeout_sec` in config file - `HOST_METERING_WRITE_TIMEOUT_SEC` env var Signed-off-by: Petr Vobornik <[email protected]>
|
What happens if the write timeout exceeds the write interval? In other words, if the timeout is greater than 10 minutes and it think it needs to send another write? |
|
Tthere would be multiple writes happening at the same time. That is something we should avoid as it might lead to erroneous behavior (sending same samples multiple times -> error from server). |
You want to tackle that here or track it as a follow up? Should we cap the timeout to less than the write interval no matter what is passed? |
|
It's bit more complicated as there are also re-tries. So it's better to tackle separately. |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Makes it possible to change timeout of http client which does Prometheus remote write via:
write_timeout_secin config fileHOST_METERING_WRITE_TIMEOUT_SECenv var