Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pulp ostree import commit #2753

Merged

Conversation

loadtheaccumulator
Copy link
Collaborator

@loadtheaccumulator loadtheaccumulator commented Nov 27, 2024

Description

Add method to use import-commit for importing a commit to an existing repo with one or more existing commits

OstreeImportCommits includes the OSTree ref for updating a tree that has at least one commit
Use OstreeImportAll via RepositoriesImport for the initial commit
(see https://pulpproject.org/pulp_ostree/docs/user/guides/import-commit/)

FIXES: HMS-4121

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

@mergify mergify bot added the new feature New feature label Nov 27, 2024
@ezr-ondrej
Copy link
Member

How is this different from RepositoriesImport ? could we add a brief comment for it? It might confuse future readers as much as I'm confused now xD

Signed-off-by: Jonathan Holloway <[email protected]>
@loadtheaccumulator
Copy link
Collaborator Author

How is this different from RepositoriesImport ?

This is for subsequent updates to an existing repo.
Comments added to both code and PR.

@mergify mergify bot added the waiting for review Need reviewers label Nov 28, 2024
Copy link
Member

@ezr-ondrej ezr-ondrej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@ezr-ondrej ezr-ondrej merged commit 47c8e31 into RedHatInsights:main Dec 2, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature waiting for review Need reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants