Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add continue after static delta #2263

Merged

Conversation

loadtheaccumulator
Copy link
Collaborator

  • add StaticDeltaStatusError to switch
  • send all errors to errChan in select

Description

Add additional handling for error'd static delta

FIXES:

Type of change

What is it?

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation update
  • Tests update
  • Refactor

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2023

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Files Coverage Δ
pkg/services/updates.go 57.15% <0.00%> (-0.45%) ⬇️

... and 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!.

@loadtheaccumulator loadtheaccumulator force-pushed the static_delta_handle_errored branch from bd214bc to a7882a3 Compare October 16, 2023 04:01
@loadtheaccumulator
Copy link
Collaborator Author

/retest

1 similar comment
@loadtheaccumulator
Copy link
Collaborator Author

/retest

@mergify mergify bot added the waiting for review Need reviewers label Oct 16, 2023
@loadtheaccumulator
Copy link
Collaborator Author

/retest

Copy link
Contributor

@ldjebran ldjebran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@de1987 de1987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@loadtheaccumulator
Copy link
Collaborator Author

@Mergifyio rebase

@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

rebase

❌ Unable to rebase: user loadtheaccumulator is unknown.

Please make sure loadtheaccumulator has logged in Mergify dashboard.

@de1987
Copy link
Contributor

de1987 commented Oct 17, 2023

@Mergifyio rebase

* add StaticDeltaStatusError to switch
* send all errors to errChan in select

Signed-off-by: Jonathan Holloway <[email protected]>
@mergify
Copy link
Contributor

mergify bot commented Oct 17, 2023

rebase

✅ Branch has been successfully rebased

@de1987 de1987 force-pushed the static_delta_handle_errored branch from a7882a3 to d0fb34c Compare October 17, 2023 20:07
@mergify mergify bot merged commit b6d829b into RedHatInsights:main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Fixes #issue waiting for review Need reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants