Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable compression in Action because the .exe file is already compressed #480

Merged
merged 5 commits into from
Feb 27, 2024

Conversation

OEMunlag
Copy link
Contributor

The packaged .exe is already compressed, the Upload build artifact action will compress the file, as the file is already compressed, the resulting size will be equal, increasing uselessly the action cpu usage, while also increasing decompression time on the end computer.

Instead, setting the compression level to 0 will zip the packaged executable, however, no compression is done, resulting in faster performance on both actions remote runners and the end user computer, with the size being the same.

@OEMunlag
Copy link
Contributor Author

OEMunlag commented Feb 22, 2024

Other commits can be ignored, because of most being master branch syncs previously commited, only the main commit seems to be able to get pushed, to be sure, check the diffs

Upgrade Upload artifact version to support compression
@OEMunlag
Copy link
Contributor Author

OEMunlag commented Feb 23, 2024

Tests seem to have worked, compared to the whole 42 seconds it used to take to upload, it now takes a mere 3 seconds, a clear improvement.

@MishaProductions
Copy link
Member

Thanks for the PR!

@MishaProductions MishaProductions merged commit 5cded2e into Rectify11:master Feb 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants