fix: back button doesn't work when URL contains hash #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replacing our no-longer-maintained history polyfill with native HTML5 History pushState and popState. browserstate/history.js#390 browserstate/history.js#276
|
Builds failing seem unrelated. @demetriusj please review. |
| @@ -189,16 +189,25 @@ if(process.env.SERVER_ENV) { | |||
| } | |||
| }); | |||
|
|
|||
| var currentLocation = location.pathname + location.search; | |||
There was a problem hiding this comment.
hey dude can you please inline this function and use a closure to not expose the currentLocation globally. additionally we will need to test if its a good idea to ignore the first pop state
There was a problem hiding this comment.
Let's test ignoring the first pop state and revise if needed.
ghost
pushed a commit
that referenced
this pull request
Mar 13, 2015
fix: back button doesn't work when URL contains hash
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing our no-longer-maintained history polyfill with native HTML5
History pushState and popState.
browserstate/history.js#390
browserstate/history.js#276