Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Implement Google Oauth login #2278

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

listiclehub1
Copy link

@listiclehub1 listiclehub1 commented Dec 2, 2024

Date: 02/12/2024

Developer Name: Utkarsh Bansal


Issue Ticket Number

Description

If the person is a developer they have to login via GitHub but a non developer should be able to login by their Google Account.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

Screenshot 1
google-login-test-local.mp4

Test Coverage

Screenshot 1 Screenshot 2024-12-02 at 3 28 25 PM

Additional Notes

  • Need to generate oauth credentials for staging as well as prod from google cloud console.
  • Design doc

controllers/auth.js Show resolved Hide resolved
controllers/auth.js Show resolved Hide resolved
controllers/auth.js Outdated Show resolved Hide resolved
controllers/auth.js Outdated Show resolved Hide resolved
controllers/auth.js Outdated Show resolved Hide resolved
models/users.js Show resolved Hide resolved
models/users.js Outdated Show resolved Hide resolved
routes/auth.ts Dismissed Show dismissed Hide dismissed
routes/auth.ts Dismissed Show dismissed Hide dismissed
controllers/auth.js Outdated Show resolved Hide resolved
controllers/auth.js Outdated Show resolved Hide resolved
Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@listiclehub1 can you please add the design doc here ?

Copy link
Member

@Achintya-Chatterjee Achintya-Chatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@listiclehub1 also you have to change the API contract

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Users can login via Google.
4 participants