Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow non super users to view skill requests & filter out skill requests not generated by non super users #153

Merged
merged 2 commits into from
Aug 31, 2024

Conversation

yesyash
Copy link
Collaborator

@yesyash yesyash commented Aug 31, 2024

Date: 1 September 2024
Developer Name: yash raj

Issue Ticket Number

Related ticket

Description

  • remove superuser check on /skills & /skills/requests API to allow non-superusers to create endorsements and view endorsements they created.
  • for non-superusers send only the skills requests created by them from the /skills/requests route.

Documentation Updated?

  • Yes
  • No

Under Feature Flag

  • Yes
  • No

Database Changes

  • Yes
  • No

Breaking Changes

  • Yes
  • No

Development Tested?

  • Yes
  • No

Screenshots

@yesyash yesyash self-assigned this Aug 31, 2024
@yesyash yesyash added the enhancement Improving something existing label Aug 31, 2024
@iamitprakash iamitprakash merged commit a7c39ec into develop Aug 31, 2024
3 checks passed
@iamitprakash iamitprakash deleted the yash/non-super-user-access branch August 31, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving something existing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants