misc clean up #254
Merged
misc clean up #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- change from local install to the standard repo based config and remove the various pre-commit tools from requirements.dev - bump versions from most tools - add an exception for feat_params.json which will never comply
- remove unnecessary non-caching-servers: use Chrome's Disable Cache feature in F12 (developer) mode - fix flake8 warnings in syll_parse.py
|
Review changes with Changed Files
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
=======================================
Coverage 88.00% 88.00%
=======================================
Files 21 21
Lines 1800 1800
Branches 326 326
=======================================
Hits 1584 1584
Misses 179 179
Partials 37 37 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Goal?
update stale and non-standard pre-commit configuration
move pre-commit dependencies out of requirements.dev.txt and only in pre commit config
remove unnecessary non-caching server scripts and clean up misc-utils
Feedback sought?
sanity check
Confidence?
high
Version change?
no