feat(YouTube): Add in app option to select a preferred language for ReVanced specific text #4231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After eventually finding the right method to override, this was way easier to implement than I expected (Android Preferences are trash). |
...nsions/shared/library/src/main/java/app/revanced/extension/shared/settings/BaseSettings.java
Outdated
Show resolved
Hide resolved
LisoUseInAIKyrios
force-pushed
the
feat/settings_in_app_language_choice
branch
from
6578fa1 to
9f3b50b
Compare
LisoUseInAIKyrios
force-pushed
the
feat/settings_in_app_language_choice
branch
from
c898ab5 to
fbf07cf
Compare
oSumAtrIX
reviewed
Dec 28, 2024
patches/src/main/kotlin/app/revanced/patches/youtube/misc/settings/SettingsPatch.kt
Show resolved
Hide resolved
oSumAtrIX
approved these changes
Dec 28, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Dec 28, 2024
# [5.8.0-dev.8](v5.8.0-dev.7...v5.8.0-dev.8) (2024-12-28) ### Features * **YouTube:** Add in app option to select a preferred language for ReVanced specific text ([#4231](#4231)) ([3932af3](3932af3))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an in app setting to pick a language for all ReVanced specific strings, while still using the original app language.
So YouTube can now use a foreign language but still show English ReVanced strings.