Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Spoof video streams): Add iOS TV client, restore iOS 'force AVC', show client type in stats for nerds #4202

Conversation

LisoUseInAIKyrios
Copy link
Contributor

@LisoUseInAIKyrios LisoUseInAIKyrios commented Dec 23, 2024

  • Adds iOS TV client type
  • Allows picking the preferred client type
  • Adds client type to stats for nerds
  • Adds iOS 'Force AVC'

All Android clients have the same limitations, except Android VR (no auth) which allows forcing a specific audio language.

@0xrxL
Copy link

0xrxL commented Dec 23, 2024

Web and MWeb clients can't be added? I tried them yesterday, but I got playback issue. Maybe there's a missing parameter?

@LisoUseInAIKyrios
Copy link
Contributor Author

https://github.com/yt-dlp/yt-dlp/blob/6fc85f617a5850307fd5b258477070e6ee177796/yt_dlp/extractor/youtube.py#L85

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Spoof video streams): Add iOS TV client type, show client type in stats for nerds fix(YouTube - Spoof video streams): Add iOS TV client, restore iOS 'force AVC', show client type in stats for nerds Dec 23, 2024
@0xrxL
Copy link

0xrxL commented Dec 23, 2024

https://github.com/yt-dlp/yt-dlp/blob/6fc85f617a5850307fd5b258477070e6ee177796/yt_dlp/extractor/youtube.py#L85

Eventually mweb can be used. It (apparently) doesn't required po-token.

@LisoUseInAIKyrios
Copy link
Contributor Author

Unless something changed in the past 3 years, 'mweb' is listed as 15fps 144p mp4/webm quality.

@oSumAtrIX
Copy link
Member

Mweb is simply the mobile client. It has pretty much all qualities as the web version

@0xrxL
Copy link

0xrxL commented Dec 23, 2024

Based on the details of this repo, it support up to 4k hdr resolutions.

https://github.com/zerodytrash/YouTube-Internal-Clients

@LisoUseInAIKyrios
Copy link
Contributor Author

@LisoUseInAIKyrios LisoUseInAIKyrios force-pushed the fix/spoof_video_streams_ios_tv branch from 70f3994 to a8c6da7 Compare December 23, 2024 18:28
@LisoUseInAIKyrios
Copy link
Contributor Author

iOS TV needs more testing, but so far it seems to be ok.

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit ab29f80 into ReVanced:dev Dec 23, 2024
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/spoof_video_streams_ios_tv branch December 23, 2024 18:39
github-actions bot pushed a commit that referenced this pull request Dec 23, 2024
## [5.7.2-dev.1](v5.7.1...v5.7.2-dev.1) (2024-12-23)

### Bug Fixes

* **YouTube - Spoof video streams:** Add iOS TV client, restore iOS 'force AVC', show client type in stats for nerds ([#4202](#4202)) ([ab29f80](ab29f80))
github-actions bot pushed a commit that referenced this pull request Dec 24, 2024
## [5.7.2](v5.7.1...v5.7.2) (2024-12-24)

### Bug Fixes

* **YouTube - Hide layout components:** Don't hide Shorts channel bar when toggling for video player ([9af6412](9af6412))
* **YouTube - Spoof video streams:** Add iOS TV client, restore iOS 'force AVC', show client type in stats for nerds ([#4202](#4202)) ([ab29f80](ab29f80))
@MarcaDian
Copy link
Contributor

iOS TV needs more testing

On iOS TV stable volume is not available.

@LisoUseInAIKyrios
Copy link
Contributor Author

Side effects were updated.

Nearly all Shorts from this channel fail to play with iOS for an unknown reason:
https://youtu.be/L5t5Ba0ABe8

An empty response is received, and maybe some parameters are missing.

@Figim
Copy link

Figim commented Dec 24, 2024

Side effects were updated.

Nearly all Shorts from this channel fail to play with iOS for an unknown reason: https://youtu.be/L5t5Ba0ABe8

An empty response is received, and maybe some parameters are missing.

When I play this channel's shorts, "statistics for nerds" shows andro vr(no auth) and it plays. iOS TV is selected in settings.

@LisoUseInAIKyrios
Copy link
Contributor Author

If a client responds with no data or an error, then it falls over to the next spoof client.

@Figim
Copy link

Figim commented Dec 24, 2024

If a client responds with no data or an error, then it falls over to the next spoof client.

Now playing on ios tv too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants