Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add reset button to custom API #2076

Merged
merged 5 commits into from
Jul 29, 2024
Merged

feat: Add reset button to custom API #2076

merged 5 commits into from
Jul 29, 2024

Conversation

Ushie
Copy link
Member

@Ushie Ushie commented Jul 23, 2024

Closes #2051

@Ushie Ushie linked an issue Jul 23, 2024 that may be closed by this pull request
feat: Add reset API to default button #2051
Closed
3 tasks
@TheAabedKhan TheAabedKhan added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Jul 24, 2024
@Ushie Ushie requested a review from Axelen123 July 25, 2024 21:59
validcube
validcube approved these changes Jul 26, 2024
View reviewed changes
Copy link
Member

@validcube validcube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪐 I would suggest making the default value or current value as the TextField's placeholder, anyway, still LGTM.

Axelen123
Axelen123 requested changes Jul 26, 2024
View reviewed changes
app/src/main/res/values/strings.xml Outdated Show resolved Hide resolved
@Ushie Ushie requested a review from Axelen123 July 28, 2024 20:55
@Ushie
Copy link
Member Author

Ushie commented Jul 28, 2024

🪐 I would suggest making the default value or current value as the TextField's placeholder, anyway, still LGTM.

That's not possible, that would be the label not the placeholder and we use label for "API URL"

@Ushie Ushie merged commit 4cbd480 into compose-dev Jul 29, 2024
2 checks passed
@Ushie Ushie deleted the feat/add-reset-api-button branch July 29, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@validcube validcube validcube approved these changes

@Axelen123 Axelen123 Axelen123 approved these changes

Assignees
No one assigned
Labels
ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager
Projects
None yet
Milestone
Release ReVanced Manager (Compose)
Development

Successfully merging this pull request may close these issues.

feat: Add reset API to default button
5 participants
@Ushie @Axelen123 @validcube @oSumAtrIX @TheAabedKhan