feat: improve patcher UI #1494

CnC-Robert · 2023-11-14T21:48:04Z

app/src/main/java/app/revanced/manager/patcher/worker/PatcherProgressManager.kt

app/src/main/java/app/revanced/manager/ui/component/ArrowButton.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

app/src/main/java/app/revanced/manager/ui/viewmodel/PatcherViewModel.kt

# Conflicts: # app/src/main/java/app/revanced/manager/di/ViewModelModule.kt # app/src/main/java/app/revanced/manager/ui/screen/settings/ContributorScreen.kt # gradle/libs.versions.toml

app/src/main/java/app/revanced/manager/MainActivity.kt

app/src/main/java/app/revanced/manager/ui/component/LoadingIndicator.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

app/src/main/java/app/revanced/manager/ui/screen/settings/update/ChangelogsScreen.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

app/src/main/java/app/revanced/manager/ui/component/LoadingIndicator.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

app/src/main/java/app/revanced/manager/ui/viewmodel/PatcherViewModel.kt

Axelen123 · 2023-12-07T16:14:00Z

Wasn't there an issue with patcher yielding too many patches that needs to be fixed?

CnC-Robert · 2023-12-07T16:23:14Z

Wasn't there an issue with patcher yielding too many patches that needs to be fixed?

Yes but i thought that wasnt the goal of this PR

Axelen123 · 2023-12-09T13:20:12Z

Wasn't there an issue with patcher yielding too many patches that needs to be fixed?

Yes but i thought that wasnt the goal of this PR

Alright then. An issue should be opened for it though

Ushie

Please move the components from the Patcher screen to their own components folder

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

app/src/main/java/app/revanced/manager/ui/component/ArrowButton.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

CnC-Robert · 2023-12-14T10:58:30Z

Please move the components from the Patcher screen to their own components folder

They're only used in PatcherScreen so i don't see why we should

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

Ushie · 2023-12-15T08:01:25Z

Please move the components from the Patcher screen to their own components folder

They're only used in PatcherScreen so i don't see why we should

It was overwhelming to look in PatcherScreen, it'd be better if the screen and the components were separated

CnC-Robert · 2023-12-15T14:33:56Z

Please move the components from the Patcher screen to their own components folder

They're only used in PatcherScreen so i don't see why we should

It was overwhelming to look in PatcherScreen, it'd be better if the screen and the components were separated

Many screens have components in the same file

…nager into compose/refactor/patcher-ui

…or/patcher-ui # Conflicts: # app/src/main/java/app/revanced/manager/ui/component/LoadingIndicator.kt # app/src/main/java/app/revanced/manager/ui/screen/InstallerScreen.kt

…o compose-dev

app/src/main/java/app/revanced/manager/patcher/Session.kt

app/src/main/java/app/revanced/manager/ui/component/LoadingIndicator.kt

app/src/main/java/app/revanced/manager/ui/component/patcher/Steps.kt

app/src/main/java/app/revanced/manager/ui/viewmodel/PatcherViewModel.kt

app/src/main/java/app/revanced/manager/ui/component/patcher/Steps.kt

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt

leskal · 2024-01-06T19:19:21Z

app/src/main/java/app/revanced/manager/ui/component/patcher/Steps.kt

+                Spacer(modifier = Modifier.weight(1f))
+
+                val stepProgress = remember(stepCount, steps) {
+                    stepCount?.let { (current, total) -> "$current/$total}" }


Suggested change

stepCount?.let { (current, total) -> "$current/$total}" }

stepCount?.let { (current, total) -> "$current/$total" }

# [1.9.0-dev.1](v1.8.0...v1.9.0-dev.1) (2024-01-23) ### Bug Fixes * broken logo in about page on release builds ([4c1ad86](4c1ad86)) * buildfile syntax ([ReVanced#66](https://github.com/BenjaminHalko/revanced-manager/issues/66)) ([b472a36](b472a36)) * bundles not loading on Android 14 ([18cfb56](18cfb56)) * contributors screen fix ([ReVanced#1256](https://github.com/BenjaminHalko/revanced-manager/issues/1256)) ([9408857](9408857)) * delete temporary files ([ReVanced#1341](https://github.com/BenjaminHalko/revanced-manager/issues/1341)) ([723f9cd](723f9cd)) * **deps:** use correct work-runtime version string ([2bb51c1](2bb51c1)) * disable `WebView` history ([ReVanced#1278](https://github.com/BenjaminHalko/revanced-manager/issues/1278)) ([a86923a](a86923a)) * don't store app list in parcel ([55f2256](55f2256)) * dont crash when the bundle cannot be downloaded ([93f3e27](93f3e27)) * exclude x86 aapt2 binary from release builds ([ReVanced#1126](https://github.com/BenjaminHalko/revanced-manager/issues/1126)) ([381daff](381daff)) * gradlew permissions on unix ([cb0150a](cb0150a)) * handle exceptions when checking for bundle updates ([32e8a37](32e8a37)) * hide patch button ([ReVanced#1284](https://github.com/BenjaminHalko/revanced-manager/issues/1284)) ([5aefb3b](5aefb3b)) * **installer:** make the correct column scrollable ([1eac42d](1eac42d)) * **installer:** progress tracking ([272d911](272d911)) * **installer:** properly track worker state ([ReVanced#32](https://github.com/BenjaminHalko/revanced-manager/issues/32)) ([971277e](971277e)) * **installer:** save step incorrectly being marked as completed ([18cbe51](18cbe51)) * **installer:** sign and install on threads ([4ae9904](4ae9904)) * **installer:** use correct bg colour for dialog ([7525e52](7525e52)) * **installer:** use correct elevation level ([d9953b1](d9953b1)) * jvm signature clash error ([4b12ae1](4b12ae1)) * library info not being embedded ([299aaa2](299aaa2)) * load patch bundles earlier ([9cab919](9cab919)) * minify crash on building release ([ReVanced#1245](https://github.com/BenjaminHalko/revanced-manager/issues/1245)) ([b4dfcf1](b4dfcf1)) * more android 34 fixes ([64ec73d](64ec73d)) * option state crash ([ReVanced#1456](https://github.com/BenjaminHalko/revanced-manager/issues/1456)) ([5fff0a2](5fff0a2)) * overlapping issue in application selection page ([ReVanced#1128](https://github.com/BenjaminHalko/revanced-manager/issues/1128)) ([372ce17](372ce17)) * parcel error for nullable types ([2bd8463](2bd8463)) * pass worker inputs without serialization ([ReVanced#44](https://github.com/BenjaminHalko/revanced-manager/issues/44)) ([4302ea8](4302ea8)) * patch options reset button being broken ([0b9889e](0b9889e)) * **patcher:** add notification and wakelock to worker; chore: add app icon ([b8a51d3](b8a51d3)) * patches not being reloaded ([9586a9c](9586a9c)) * **patches selector:** copy the selected patches list ([762bfa8](762bfa8)) * perform selected app operations in the correct order ([cc89784](cc89784)) * permission error when using installed app ([f6563b2](f6563b2)) * progress bar not updating ([f38b31a](f38b31a)) * providers.gradleProperty ([ReVanced#1223](https://github.com/BenjaminHalko/revanced-manager/issues/1223)) ([0b0ba21](0b0ba21)) * release builds not working properly ([d2dcd42](d2dcd42)) * remove misc.xml and kotlinc.xml ([1f8341a](1f8341a)) * run blocking IO operations in the correct context ([535efa3](535efa3)) * serialization not working ([1331479](1331479)) * sources screen being misaligned during transitions ([149c8cc](149c8cc)) * specify `multithreadingDexFileWriter` in `PatcherOptions` ([ReVanced#1402](https://github.com/BenjaminHalko/revanced-manager/issues/1402)) ([12b00e5](12b00e5)) * typo in string name `import_keystore_description` ([ReVanced#1273](https://github.com/BenjaminHalko/revanced-manager/issues/1273)) ([6f2ca5b](6f2ca5b)) * **ui:** make entire patches view button selectable ([ReVanced#1271](https://github.com/BenjaminHalko/revanced-manager/issues/1271)) ([e0f8d06](e0f8d06)) * universal patches not selectable ([c6ac898](c6ac898)) * Updates popup shows incorrect names ([ReVanced#1283](https://github.com/BenjaminHalko/revanced-manager/issues/1283)) ([65377ff](65377ff)) * use correct `getViewModel` ([1be9c9c](1be9c9c)) * use correct checksum ([7d887c7](7d887c7)) * use correct classes to determine option type ([abf4d91](abf4d91)) * use correct directory ([3b65cd0](3b65cd0)) * use i18n translation for installer page ([72fd24e](72fd24e)) * use ReVanced ring logo in about section ([ReVanced#1302](https://github.com/BenjaminHalko/revanced-manager/issues/1302)) ([f79320c](f79320c)) * use upsert when modifying installed apps ([9df98ed](9df98ed)) ### Features * **about screen:** complete about screen ([fec8c0c](fec8c0c)) * add checkboxes to the downloaded apps page ([e70c10a](e70c10a)) * add patch bundle info screen ([ReVanced#55](https://github.com/BenjaminHalko/revanced-manager/issues/55)) ([21d99a1](21d99a1)) * add patches selector bottom sheet ([ReVanced#1360](https://github.com/BenjaminHalko/revanced-manager/issues/1360)) ([5762859](5762859)) * add toast feedback to the bundle update button ([607d8b6](607d8b6)) * add user agent ([ReVanced#1382](https://github.com/BenjaminHalko/revanced-manager/issues/1382)) ([212e55f](212e55f)) * advanced settings page with device info ([ReVanced#51](https://github.com/BenjaminHalko/revanced-manager/issues/51)) ([453f4da](453f4da)) * allow user to save logs ([d9d83df](d9d83df)) * animate the arrow button ([4868c45](4868c45)) * app downloader ([ReVanced#43](https://github.com/BenjaminHalko/revanced-manager/issues/43)) ([94a4dba](94a4dba)) * app selector screen ([54f0a69](54f0a69)) * **app-selector:** show patchable installed apps first ([ReVanced#1496](https://github.com/BenjaminHalko/revanced-manager/issues/1496)) ([d55abf5](d55abf5)) * armv7 warning ([8f54495](8f54495)) * backend ([e5d898f](e5d898f)) * better installer ui ([ReVanced#29](https://github.com/BenjaminHalko/revanced-manager/issues/29)) ([399fc98](399fc98)) * **bundles tab:** add BackHandler ([757840b](757840b)) * change appID and name of debug builds ([4cb4ce2](4cb4ce2)) * **Changelogs:** overall improvement ([ReVanced#1429](https://github.com/BenjaminHalko/revanced-manager/issues/1429)) ([1a83315](1a83315)) * check for updates on startup ([ReVanced#1462](https://github.com/BenjaminHalko/revanced-manager/issues/1462)) ([1dc41ba](1dc41ba)) * contributors screen ([ReVanced#42](https://github.com/BenjaminHalko/revanced-manager/issues/42)) ([0dccb8c](0dccb8c)) * **Contributors Screen:** implement design from Figma ([ReVanced#1465](https://github.com/BenjaminHalko/revanced-manager/issues/1465)) ([62a5fce](62a5fce)) * Dashboard Screen ([ReVanced#18](https://github.com/BenjaminHalko/revanced-manager/issues/18)) ([9065c0d](9065c0d)) * disable changing patches selection by default ([ReVanced#1132](https://github.com/BenjaminHalko/revanced-manager/issues/1132)) ([c400619](c400619)) * disable filter chips when there are no patches ([5d3b963](5d3b963)) * download apps in patcher screen ([ReVanced#73](https://github.com/BenjaminHalko/revanced-manager/issues/73)) ([aec8cec](aec8cec)) * experimental patches setting ([9dd74f1](9dd74f1)) * filter options for patches ([6309e8b](6309e8b)) * finish implementing the sources system ([ReVanced#70](https://github.com/BenjaminHalko/revanced-manager/issues/70)) ([379ce91](379ce91)) * hide tabs when 1 bundle is used ([ffa8d9c](ffa8d9c)) * hide unfinished pages in release mode ([f5b3b29](f5b3b29)) * implement DI ([57e2632](57e2632)) * implement navigation ([9536cdc](9536cdc)) * implement Submit Issue button ([ReVanced#1276](https://github.com/BenjaminHalko/revanced-manager/issues/1276)) ([cf71ea2](cf71ea2)) * improve accessibility ([ReVanced#64](https://github.com/BenjaminHalko/revanced-manager/issues/64)) ([cd2587b](cd2587b)) * improve bundle dialog UI ([1707a96](1707a96)) * improve keystore UI and UX ([ReVanced#52](https://github.com/BenjaminHalko/revanced-manager/issues/52)) ([aa02e9f](aa02e9f)) * improve patcher UI ([ReVanced#1494](https://github.com/BenjaminHalko/revanced-manager/issues/1494)) ([3232bb1](3232bb1)) * improved compose stability ([fcb75dd](fcb75dd)) * improved dashboard screen ([f1656c6](f1656c6)) * in-app updater ([ReVanced#25](https://github.com/BenjaminHalko/revanced-manager/issues/25)) ([a4842c0](a4842c0)) * initialize project ([b372f7e](b372f7e)) * **installer:** adjust arrow icon size ([39caad1](39caad1)) * **installer:** adjust step icon size and alignment ([6437f7b](6437f7b)) * **installer:** apk signing and installation ([52ab793](52ab793)) * **installer:** redesign utility options ([ReVanced#1062](https://github.com/BenjaminHalko/revanced-manager/issues/1062)) ([b77d46b](b77d46b)) * **installer:** sign apk in patcher worker ([172604f](172604f)) * **Installer:** use BottomAppBar ([ReVanced#1428](https://github.com/BenjaminHalko/revanced-manager/issues/1428)) ([3c57762](3c57762)) * integrate revanced patcher ([ReVanced#22](https://github.com/BenjaminHalko/revanced-manager/issues/22)) ([4048792](4048792)) * keystore import/export ([ReVanced#30](https://github.com/BenjaminHalko/revanced-manager/issues/30)) ([919b6b7](919b6b7)) * **koin:** use the android logger ([7ce4de7](7ce4de7)) * licenses screen ([ReVanced#47](https://github.com/BenjaminHalko/revanced-manager/issues/47)) ([6b7143d](6b7143d)) * make bundles selectable ([ReVanced#1237](https://github.com/BenjaminHalko/revanced-manager/issues/1237)) ([42e0346](42e0346)) * more info for the select from application screen ([ReVanced#81](https://github.com/BenjaminHalko/revanced-manager/issues/81)) ([3cfa4ea](3cfa4ea)) * **NotificationCard:** rewrite & consistent usage ([ReVanced#1426](https://github.com/BenjaminHalko/revanced-manager/issues/1426)) ([7741394](7741394)) * patch apps without internet ([ReVanced#1114](https://github.com/BenjaminHalko/revanced-manager/issues/1114)) ([f90f6e8](f90f6e8)) * patch bundle sources system ([ReVanced#24](https://github.com/BenjaminHalko/revanced-manager/issues/24)) ([c22371e](c22371e)) * patch options ([ReVanced#45](https://github.com/BenjaminHalko/revanced-manager/issues/45)) ([01fd4c8](01fd4c8)) * patch options UI ([ReVanced#80](https://github.com/BenjaminHalko/revanced-manager/issues/80)) ([7aea947](7aea947)) * **patch-selector:** default patches selection ([ReVanced#1272](https://github.com/BenjaminHalko/revanced-manager/issues/1272)) ([f78b56e](f78b56e)) * **patch-selector:** remove TODO about an unplanned feature ([5290713](5290713)) * patches selector screen ([4c3dbbd](4c3dbbd)) * prereleases ([9e344a9](9e344a9)) * ProGuard ([9591f4e](9591f4e)) * Purple default theme ([ReVanced#1601](https://github.com/BenjaminHalko/revanced-manager/issues/1601)) ([d9d7b98](d9d7b98)) * remember patch options ([ReVanced#1449](https://github.com/BenjaminHalko/revanced-manager/issues/1449)) ([7fe4724](7fe4724)) * remove dead help icons ([ca3c9af](ca3c9af)) * rename package to `app.revanced.manager` ([27426b1](27426b1)) * rename ViewModels for consistency ([e088d05](e088d05)) * ReVanced theme colors ([955e7a4](955e7a4)) * root installation ([ReVanced#1243](https://github.com/BenjaminHalko/revanced-manager/issues/1243)) ([bf10af2](bf10af2)) * save patch options and selected patches in bundle ([ReVanced#50](https://github.com/BenjaminHalko/revanced-manager/issues/50)) ([8dd8f88](8dd8f88)) * save patch selection using room db ([ReVanced#38](https://github.com/BenjaminHalko/revanced-manager/issues/38)) ([923ce74](923ce74)) * Scrollbars ([ReVanced#1479](https://github.com/BenjaminHalko/revanced-manager/issues/1479)) ([36c8f59](36c8f59)) * Select bundle type before adding bundle ([ReVanced#1490](https://github.com/BenjaminHalko/revanced-manager/issues/1490)) ([aa6e612](aa6e612)) * selected app info page ([ReVanced#1395](https://github.com/BenjaminHalko/revanced-manager/issues/1395)) ([c3af6ac](c3af6ac)) * settings migration (compose) ([ReVanced#1309](https://github.com/BenjaminHalko/revanced-manager/issues/1309)) ([56a4a70](56a4a70)) * settings screen ([4088ed7](4088ed7)) * **settings screen:** add battery optimization notification ([c332760](c332760)) * **settings screen:** match typography from figma ([9b585c7](9b585c7)) * **settings:** move experimental patches option to advanced ([d8392ad](d8392ad)) * **Settings:** use SettingsListItem consistently and overall improvements ([ReVanced#1427](https://github.com/BenjaminHalko/revanced-manager/issues/1427)) ([25bd91d](25bd91d)) * show installed app in version selector ([61de0b6](61de0b6)) * show stacktrace in installer ui ([ReVanced#36](https://github.com/BenjaminHalko/revanced-manager/issues/36)) ([5681c91](5681c91)) * show toast when no patches are selected ([65f8d38](65f8d38)) * splash screen ([49f9dfc](49f9dfc)) * store patched apps ([ReVanced#79](https://github.com/BenjaminHalko/revanced-manager/issues/79)) ([a0b9255](a0b9255)) * switch to Preferences DataStore ([ReVanced#60](https://github.com/BenjaminHalko/revanced-manager/issues/60)) ([879884a](879884a)) * switch to the new api ([ReVanced#75](https://github.com/BenjaminHalko/revanced-manager/issues/75)) ([3f059d7](3f059d7)) * **Update Screen:** changelogs & handle states ([ReVanced#1464](https://github.com/BenjaminHalko/revanced-manager/issues/1464)) ([bd9778a](bd9778a)) * **update screen:** complete main update screen ([ea4247c](ea4247c)) * updater changelogs ([ReVanced#48](https://github.com/BenjaminHalko/revanced-manager/issues/48)) ([fe5e191](fe5e191)) * updater UI and code improvements ([ReVanced#1597](https://github.com/BenjaminHalko/revanced-manager/issues/1597)) ([b7cb6b9](b7cb6b9)) * Use correct casing in module description ([ac561e7](ac561e7)) * use revanced api for changelogs ([608bac6](608bac6)) ### Reverts * downgrade Kotlin to 1.8.21 ([37e177b](37e177b))

# [1.9.0-dev.1](v1.8.0...v1.9.0-dev.1) (2024-01-23) ### Bug Fixes * broken logo in about page on release builds ([4c1ad86](4c1ad86)) * buildfile syntax ([ReVanced#66](https://github.com/BenjaminHalko/revanced-manager/issues/66)) ([b472a36](b472a36)) * bundles not loading on Android 14 ([18cfb56](18cfb56)) * contributors screen fix ([ReVanced#1256](https://github.com/BenjaminHalko/revanced-manager/issues/1256)) ([9408857](9408857)) * delete temporary files ([ReVanced#1341](https://github.com/BenjaminHalko/revanced-manager/issues/1341)) ([723f9cd](723f9cd)) * **deps:** use correct work-runtime version string ([2bb51c1](2bb51c1)) * disable `WebView` history ([ReVanced#1278](https://github.com/BenjaminHalko/revanced-manager/issues/1278)) ([a86923a](a86923a)) * don't store app list in parcel ([55f2256](55f2256)) * dont crash when the bundle cannot be downloaded ([93f3e27](93f3e27)) * exclude x86 aapt2 binary from release builds ([ReVanced#1126](https://github.com/BenjaminHalko/revanced-manager/issues/1126)) ([381daff](381daff)) * gradlew permissions on unix ([cb0150a](cb0150a)) * handle exceptions when checking for bundle updates ([32e8a37](32e8a37)) * hide patch button ([ReVanced#1284](https://github.com/BenjaminHalko/revanced-manager/issues/1284)) ([5aefb3b](5aefb3b)) * **installer:** make the correct column scrollable ([1eac42d](1eac42d)) * **installer:** progress tracking ([272d911](272d911)) * **installer:** properly track worker state ([ReVanced#32](https://github.com/BenjaminHalko/revanced-manager/issues/32)) ([971277e](971277e)) * **installer:** save step incorrectly being marked as completed ([18cbe51](18cbe51)) * **installer:** sign and install on threads ([4ae9904](4ae9904)) * **installer:** use correct bg colour for dialog ([7525e52](7525e52)) * **installer:** use correct elevation level ([d9953b1](d9953b1)) * jvm signature clash error ([4b12ae1](4b12ae1)) * library info not being embedded ([299aaa2](299aaa2)) * load patch bundles earlier ([9cab919](9cab919)) * minify crash on building release ([ReVanced#1245](https://github.com/BenjaminHalko/revanced-manager/issues/1245)) ([b4dfcf1](b4dfcf1)) * more android 34 fixes ([64ec73d](64ec73d)) * option state crash ([ReVanced#1456](https://github.com/BenjaminHalko/revanced-manager/issues/1456)) ([5fff0a2](5fff0a2)) * overlapping issue in application selection page ([ReVanced#1128](https://github.com/BenjaminHalko/revanced-manager/issues/1128)) ([372ce17](372ce17)) * parcel error for nullable types ([2bd8463](2bd8463)) * pass worker inputs without serialization ([ReVanced#44](https://github.com/BenjaminHalko/revanced-manager/issues/44)) ([4302ea8](4302ea8)) * patch options reset button being broken ([0b9889e](0b9889e)) * **patcher:** add notification and wakelock to worker; chore: add app icon ([b8a51d3](b8a51d3)) * patches not being reloaded ([9586a9c](9586a9c)) * **patches selector:** copy the selected patches list ([762bfa8](762bfa8)) * perform selected app operations in the correct order ([cc89784](cc89784)) * permission error when using installed app ([f6563b2](f6563b2)) * progress bar not updating ([f38b31a](f38b31a)) * providers.gradleProperty ([ReVanced#1223](https://github.com/BenjaminHalko/revanced-manager/issues/1223)) ([0b0ba21](0b0ba21)) * release builds not working properly ([d2dcd42](d2dcd42)) * remove misc.xml and kotlinc.xml ([1f8341a](1f8341a)) * run blocking IO operations in the correct context ([535efa3](535efa3)) * serialization not working ([1331479](1331479)) * sources screen being misaligned during transitions ([149c8cc](149c8cc)) * specify `multithreadingDexFileWriter` in `PatcherOptions` ([ReVanced#1402](https://github.com/BenjaminHalko/revanced-manager/issues/1402)) ([12b00e5](12b00e5)) * typo in string name `import_keystore_description` ([ReVanced#1273](https://github.com/BenjaminHalko/revanced-manager/issues/1273)) ([6f2ca5b](6f2ca5b)) * **ui:** make entire patches view button selectable ([ReVanced#1271](https://github.com/BenjaminHalko/revanced-manager/issues/1271)) ([e0f8d06](e0f8d06)) * universal patches not selectable ([c6ac898](c6ac898)) * Updates popup shows incorrect names ([ReVanced#1283](https://github.com/BenjaminHalko/revanced-manager/issues/1283)) ([65377ff](65377ff)) * use correct `getViewModel` ([1be9c9c](1be9c9c)) * use correct checksum ([7d887c7](7d887c7)) * use correct classes to determine option type ([abf4d91](abf4d91)) * use correct directory ([3b65cd0](3b65cd0)) * use i18n translation for installer page ([72fd24e](72fd24e)) * use ReVanced ring logo in about section ([ReVanced#1302](https://github.com/BenjaminHalko/revanced-manager/issues/1302)) ([f79320c](f79320c)) * use upsert when modifying installed apps ([9df98ed](9df98ed)) ### Features * **about screen:** complete about screen ([fec8c0c](fec8c0c)) * add checkboxes to the downloaded apps page ([e70c10a](e70c10a)) * add patch bundle info screen ([ReVanced#55](https://github.com/BenjaminHalko/revanced-manager/issues/55)) ([21d99a1](21d99a1)) * add patches selector bottom sheet ([ReVanced#1360](https://github.com/BenjaminHalko/revanced-manager/issues/1360)) ([5762859](5762859)) * add toast feedback to the bundle update button ([607d8b6](607d8b6)) * add user agent ([ReVanced#1382](https://github.com/BenjaminHalko/revanced-manager/issues/1382)) ([212e55f](212e55f)) * advanced settings page with device info ([ReVanced#51](https://github.com/BenjaminHalko/revanced-manager/issues/51)) ([453f4da](453f4da)) * allow user to save logs ([d9d83df](d9d83df)) * animate the arrow button ([4868c45](4868c45)) * app downloader ([ReVanced#43](https://github.com/BenjaminHalko/revanced-manager/issues/43)) ([94a4dba](94a4dba)) * app selector screen ([54f0a69](54f0a69)) * **app-selector:** show patchable installed apps first ([ReVanced#1496](https://github.com/BenjaminHalko/revanced-manager/issues/1496)) ([d55abf5](d55abf5)) * armv7 warning ([8f54495](8f54495)) * backend ([e5d898f](e5d898f)) * better installer ui ([ReVanced#29](https://github.com/BenjaminHalko/revanced-manager/issues/29)) ([399fc98](399fc98)) * **bundles tab:** add BackHandler ([757840b](757840b)) * change appID and name of debug builds ([4cb4ce2](4cb4ce2)) * **Changelogs:** overall improvement ([ReVanced#1429](https://github.com/BenjaminHalko/revanced-manager/issues/1429)) ([1a83315](1a83315)) * check for updates on startup ([ReVanced#1462](https://github.com/BenjaminHalko/revanced-manager/issues/1462)) ([1dc41ba](1dc41ba)) * contributors screen ([ReVanced#42](https://github.com/BenjaminHalko/revanced-manager/issues/42)) ([0dccb8c](0dccb8c)) * **Contributors Screen:** implement design from Figma ([ReVanced#1465](https://github.com/BenjaminHalko/revanced-manager/issues/1465)) ([62a5fce](62a5fce)) * Dashboard Screen ([ReVanced#18](https://github.com/BenjaminHalko/revanced-manager/issues/18)) ([9065c0d](9065c0d)) * disable changing patches selection by default ([ReVanced#1132](https://github.com/BenjaminHalko/revanced-manager/issues/1132)) ([c400619](c400619)) * disable filter chips when there are no patches ([5d3b963](5d3b963)) * download apps in patcher screen ([ReVanced#73](https://github.com/BenjaminHalko/revanced-manager/issues/73)) ([aec8cec](aec8cec)) * experimental patches setting ([9dd74f1](9dd74f1)) * filter options for patches ([6309e8b](6309e8b)) * finish implementing the sources system ([ReVanced#70](https://github.com/BenjaminHalko/revanced-manager/issues/70)) ([379ce91](379ce91)) * hide tabs when 1 bundle is used ([ffa8d9c](ffa8d9c)) * hide unfinished pages in release mode ([f5b3b29](f5b3b29)) * implement DI ([57e2632](57e2632)) * implement navigation ([9536cdc](9536cdc)) * implement Submit Issue button ([ReVanced#1276](https://github.com/BenjaminHalko/revanced-manager/issues/1276)) ([cf71ea2](cf71ea2)) * improve accessibility ([ReVanced#64](https://github.com/BenjaminHalko/revanced-manager/issues/64)) ([cd2587b](cd2587b)) * improve bundle dialog UI ([1707a96](1707a96)) * improve keystore UI and UX ([ReVanced#52](https://github.com/BenjaminHalko/revanced-manager/issues/52)) ([aa02e9f](aa02e9f)) * improve patcher UI ([ReVanced#1494](https://github.com/BenjaminHalko/revanced-manager/issues/1494)) ([3232bb1](3232bb1)) * improved compose stability ([fcb75dd](fcb75dd)) * improved dashboard screen ([f1656c6](f1656c6)) * in-app updater ([ReVanced#25](https://github.com/BenjaminHalko/revanced-manager/issues/25)) ([a4842c0](a4842c0)) * initialize project ([b372f7e](b372f7e)) * **installer:** adjust arrow icon size ([39caad1](39caad1)) * **installer:** adjust step icon size and alignment ([6437f7b](6437f7b)) * **installer:** apk signing and installation ([52ab793](52ab793)) * **installer:** redesign utility options ([ReVanced#1062](https://github.com/BenjaminHalko/revanced-manager/issues/1062)) ([b77d46b](b77d46b)) * **installer:** sign apk in patcher worker ([172604f](172604f)) * **Installer:** use BottomAppBar ([ReVanced#1428](https://github.com/BenjaminHalko/revanced-manager/issues/1428)) ([3c57762](3c57762)) * integrate revanced patcher ([ReVanced#22](https://github.com/BenjaminHalko/revanced-manager/issues/22)) ([4048792](4048792)) * keystore import/export ([ReVanced#30](https://github.com/BenjaminHalko/revanced-manager/issues/30)) ([919b6b7](919b6b7)) * **koin:** use the android logger ([7ce4de7](7ce4de7)) * licenses screen ([ReVanced#47](https://github.com/BenjaminHalko/revanced-manager/issues/47)) ([6b7143d](6b7143d)) * make bundles selectable ([ReVanced#1237](https://github.com/BenjaminHalko/revanced-manager/issues/1237)) ([42e0346](42e0346)) * more info for the select from application screen ([ReVanced#81](https://github.com/BenjaminHalko/revanced-manager/issues/81)) ([3cfa4ea](3cfa4ea)) * **NotificationCard:** rewrite & consistent usage ([ReVanced#1426](https://github.com/BenjaminHalko/revanced-manager/issues/1426)) ([7741394](7741394)) * patch apps without internet ([ReVanced#1114](https://github.com/BenjaminHalko/revanced-manager/issues/1114)) ([f90f6e8](f90f6e8)) * patch bundle sources system ([ReVanced#24](https://github.com/BenjaminHalko/revanced-manager/issues/24)) ([c22371e](c22371e)) * patch options ([ReVanced#45](https://github.com/BenjaminHalko/revanced-manager/issues/45)) ([01fd4c8](01fd4c8)) * patch options UI ([ReVanced#80](https://github.com/BenjaminHalko/revanced-manager/issues/80)) ([7aea947](7aea947)) * **patch-selector:** default patches selection ([ReVanced#1272](https://github.com/BenjaminHalko/revanced-manager/issues/1272)) ([f78b56e](f78b56e)) * **patch-selector:** remove TODO about an unplanned feature ([5290713](5290713)) * patches selector screen ([4c3dbbd](4c3dbbd)) * prereleases ([9e344a9](9e344a9)) * ProGuard ([9591f4e](9591f4e)) * Purple default theme ([ReVanced#1601](https://github.com/BenjaminHalko/revanced-manager/issues/1601)) ([d9d7b98](d9d7b98)) * remember patch options ([ReVanced#1449](https://github.com/BenjaminHalko/revanced-manager/issues/1449)) ([7fe4724](7fe4724)) * remove dead help icons ([ca3c9af](ca3c9af)) * rename package to `app.revanced.manager` ([27426b1](27426b1)) * rename ViewModels for consistency ([e088d05](e088d05)) * ReVanced theme colors ([955e7a4](955e7a4)) * root installation ([ReVanced#1243](https://github.com/BenjaminHalko/revanced-manager/issues/1243)) ([bf10af2](bf10af2)) * save patch options and selected patches in bundle ([ReVanced#50](https://github.com/BenjaminHalko/revanced-manager/issues/50)) ([8dd8f88](8dd8f88)) * save patch selection using room db ([ReVanced#38](https://github.com/BenjaminHalko/revanced-manager/issues/38)) ([923ce74](923ce74)) * Scrollbars ([ReVanced#1479](https://github.com/BenjaminHalko/revanced-manager/issues/1479)) ([36c8f59](36c8f59)) * Select bundle type before adding bundle ([ReVanced#1490](https://github.com/BenjaminHalko/revanced-manager/issues/1490)) ([aa6e612](aa6e612)) * selected app info page ([ReVanced#1395](https://github.com/BenjaminHalko/revanced-manager/issues/1395)) ([c3af6ac](c3af6ac)) * settings migration (compose) ([ReVanced#1309](https://github.com/BenjaminHalko/revanced-manager/issues/1309)) ([56a4a70](56a4a70)) * settings screen ([4088ed7](4088ed7)) * **settings screen:** add battery optimization notification ([c332760](c332760)) * **settings screen:** match typography from figma ([9b585c7](9b585c7)) * **settings:** move experimental patches option to advanced ([d8392ad](d8392ad)) * **Settings:** use SettingsListItem consistently and overall improvements ([ReVanced#1427](https://github.com/BenjaminHalko/revanced-manager/issues/1427)) ([25bd91d](25bd91d)) * show installed app in version selector ([61de0b6](61de0b6)) * show stacktrace in installer ui ([ReVanced#36](https://github.com/BenjaminHalko/revanced-manager/issues/36)) ([5681c91](5681c91)) * show toast when no patches are selected ([65f8d38](65f8d38)) * store patched apps ([ReVanced#79](https://github.com/BenjaminHalko/revanced-manager/issues/79)) ([a0b9255](a0b9255)) * switch to Preferences DataStore ([ReVanced#60](https://github.com/BenjaminHalko/revanced-manager/issues/60)) ([879884a](879884a)) * switch to the new api ([ReVanced#75](https://github.com/BenjaminHalko/revanced-manager/issues/75)) ([3f059d7](3f059d7)) * **Update Screen:** changelogs & handle states ([ReVanced#1464](https://github.com/BenjaminHalko/revanced-manager/issues/1464)) ([bd9778a](bd9778a)) * **update screen:** complete main update screen ([ea4247c](ea4247c)) * updater changelogs ([ReVanced#48](https://github.com/BenjaminHalko/revanced-manager/issues/48)) ([fe5e191](fe5e191)) * updater UI and code improvements ([ReVanced#1597](https://github.com/BenjaminHalko/revanced-manager/issues/1597)) ([b7cb6b9](b7cb6b9)) * Use correct casing in module description ([ac561e7](ac561e7)) * use revanced api for changelogs ([608bac6](608bac6)) ### Reverts * downgrade Kotlin to 1.8.21 ([37e177b](37e177b))

refactor: patcher ui

9fda820

CnC-Robert requested a review from Axelen123 November 14, 2023 21:48

validcube added the ReVanced Manager Compose Regarding the Compose rewrite of ReVanced Manager label Nov 14, 2023

Axelen123 requested changes Nov 15, 2023

View reviewed changes

Axelen123 requested changes Nov 16, 2023

View reviewed changes

CnC-Robert added 3 commits December 1, 2023 19:42

feat: store progress in ViewModel

c599c2a

feat: use string resources

0d627ef

Merge remote-tracking branch 'origin/compose-dev' into compose-dev

385215f

# Conflicts: # app/src/main/java/app/revanced/manager/di/ViewModelModule.kt # app/src/main/java/app/revanced/manager/ui/screen/settings/ContributorScreen.kt # gradle/libs.versions.toml

CnC-Robert requested a review from Axelen123 December 1, 2023 19:50

CnC-Robert marked this pull request as ready for review December 1, 2023 19:50

bruh

169dbcb

Axelen123 requested changes Dec 1, 2023

View reviewed changes

Ushie self-requested a review December 1, 2023 21:27

rename destination

98e2ad6

CnC-Robert requested a review from Axelen123 December 1, 2023 21:31

Axelen123 requested changes Dec 3, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt Outdated Show resolved Hide resolved

stuff

33b8a7c

CnC-Robert requested a review from Axelen123 December 6, 2023 14:10

a

87af7e3

Axelen123 requested changes Dec 7, 2023

View reviewed changes

Ushie requested changes Dec 10, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt Outdated Show resolved Hide resolved

Ushie requested changes Dec 10, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/ArrowButton.kt Outdated Show resolved Hide resolved

Ushie reviewed Dec 10, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt Outdated Show resolved Hide resolved

m

b1732af

Axelen123 reviewed Dec 14, 2023

View reviewed changes

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt Outdated Show resolved Hide resolved

Ushie changed the title ~~refactor: patcher UI~~ feat: improve patcher UI Dec 15, 2023

Ushie added 3 commits December 25, 2023 23:46

refactor: Move Steps to components

77d640e

refactor: Move InstallPickerDialog to components

74f0b2f

feat: Minor UI adjustment and refactor

d7b0926

Ushie force-pushed the compose/refactor/patcher-ui branch from 1b5b53f to d7b0926 Compare December 25, 2023 21:43

Ushie added 3 commits December 26, 2023 09:54

refactor: Use LazyColumn instead of Box

c5fa503

Merge branch 'compose-dev' of https://github.com/ReVanced/revanced-ma…

73833c5

…nager into compose/refactor/patcher-ui

Merge remote-tracking branch 'origin/compose-dev' into compose/refact…

a91bf60

…or/patcher-ui # Conflicts: # app/src/main/java/app/revanced/manager/ui/component/LoadingIndicator.kt # app/src/main/java/app/revanced/manager/ui/screen/InstallerScreen.kt

Ushie force-pushed the compose/refactor/patcher-ui branch from 8aa1c03 to a91bf60 Compare December 26, 2023 20:56

CnC-Robert added 2 commits January 5, 2024 20:54

Handle patches step in worker

5bf78e1

Merge remote-tracking branch 'origin/compose/refactor/patcher-ui' int…

6aa22b4

…o compose-dev

CnC-Robert requested a review from Axelen123 January 5, 2024 19:56

Axelen123 requested changes Jan 5, 2024

View reviewed changes

o

7e2a477

Axelen123 requested changes Jan 6, 2024

View reviewed changes

app/src/main/java/app/revanced/manager/ui/component/patcher/Steps.kt Outdated Show resolved Hide resolved

app/src/main/java/app/revanced/manager/ui/screen/PatcherScreen.kt Outdated Show resolved Hide resolved

g

34ce3b4

CnC-Robert requested a review from Axelen123 January 6, 2024 15:29

Axelen123 approved these changes Jan 6, 2024

View reviewed changes

CnC-Robert merged commit 3232bb1 into compose-dev Jan 6, 2024
2 checks passed

leskal reviewed Jan 6, 2024

View reviewed changes

Ushie deleted the compose/refactor/patcher-ui branch January 10, 2024 11:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: improve patcher UI #1494

feat: improve patcher UI #1494

CnC-Robert commented Nov 14, 2023 •

edited

Loading

Axelen123 commented Dec 7, 2023

CnC-Robert commented Dec 7, 2023

Axelen123 commented Dec 9, 2023

Ushie left a comment

CnC-Robert commented Dec 14, 2023

Ushie commented Dec 15, 2023

CnC-Robert commented Dec 15, 2023

leskal Jan 6, 2024

	stepCount?.let { (current, total) -> "$current/$total}" }
	stepCount?.let { (current, total) -> "$current/$total" }

feat: improve patcher UI #1494

feat: improve patcher UI #1494

Conversation

CnC-Robert commented Nov 14, 2023 • edited Loading

Axelen123 commented Dec 7, 2023

CnC-Robert commented Dec 7, 2023

Axelen123 commented Dec 9, 2023

Ushie left a comment

Choose a reason for hiding this comment

CnC-Robert commented Dec 14, 2023

Ushie commented Dec 15, 2023

CnC-Robert commented Dec 15, 2023

leskal Jan 6, 2024

Choose a reason for hiding this comment

CnC-Robert commented Nov 14, 2023 •

edited

Loading