Bugfixes & Cleanup #120

BrentDaMage · 2024-04-17T04:57:12Z

Cleaned up GameMods.hpp & fixed all macro toggles
Made world border unpickable/unhighlightable
Lowered mob reach range for creative mode from 32 blocks to 7 (as in 0.12.1)
Fixed uninitialized variables (bugs could appear depending on the compiler)
- "PathfinderMob::m_pAttackTarget" (caused a crash)
- "Entity::field_C4" (caused entities to suffocate always)
Fixed Random.cpp for compilation with C++03 by using "std::numeric_limits" instead of "INFINITY"
Documented Texture::field_C as m_hasAlpha
Deleted unused "GLTexture" struct
Removed ModelPart::renderHorrible
Added other mob textures to .gitignore

GameMods.hpp

source/client/model/Cube.cpp

source/client/model/ModelPart.cpp

iProgramMC

This looks good to me. But I would like an answer to these reviews.

platforms/sdl/main.cpp

BrentDaMage · 2024-04-20T02:00:50Z

The pull-request build checks are not accurate reflections of the build checks on my bugfix-cleanup branch.

iProgramMC · 2024-04-20T05:46:15Z

It probably does. See https://github.com/ReMinecraftPE/mcpe/actions/runs/8761750741/job/24048662614?pr=120#step:4:244

You didn't rename Texture::field_C to m_bHasAlpha fully, apparently.

BrentDaMage · 2024-04-20T05:54:53Z

It probably does. See https://github.com/ReMinecraftPE/mcpe/actions/runs/8761750741/job/24048662614?pr=120#step:4:244

You didn't rename Texture::field_C to m_bHasAlpha fully, apparently.

No? Look at my latest commit on bugfix-cleanup. All of its checks passed.

source/client/app/Minecraft.hpp

source/network/Packet.hpp

source/network/packets/StartGamePacket.cpp

source/world/gamemode/CreativeMode.cpp

* Cleaned up GameMods.hpp & fixed all macro toggles * Made world border unpickable/unhighlightable * Lowered mob reach range for creative mode from 32 blocks to 7 (as in 0.12.1) * Fixed uninitialized variables (bugs could appear depending on the compiler) * "PathfinderMob::m_pAttackTarget" (caused a crash) * "Entity::field_C4" (caused entities to suffocate always) * Fixed Random.cpp for compilation with C++03 by using "std::numeric_limits" instead of "INFINITY" * Documented Texture::field_C as m_hasAlpha * Deleted unused "GLTexture" struct * Removed ModelPart::renderHorrible * Added other mob textures to .gitignore

* It still does not work. I'm not even sure how it broke in the first place.

* Added option & enhancement macro for enabling/disabling the panorama menu background

* Fixed a bug which caused mobs to not catch fire * Added Flint, Porkchops, and Eggs * Mobs can now drop loot upon death * Added Chickens * Added scaffolding for gamemodes in replication and level data. This can be enabled with 'TEST_GAMEMODE_REPLICATION'. * Documented a number of variables

* Add EntityType * Add MobFactory * Add PacketUtil * Remove TLong/LongHack remnants * Remove old minecraftcpp.vcxproj file

* Reverted protocol version back to 2

* Added Cow * Made tons of stuff const * Fixed-ish pathfinding

…reason

source/world/entity/MobFactory.hpp

source/world/entity/EntityType.hpp

* Replaced global variable with LevelRenderer::areCloudsAvailable()

* Fixed crashing from moving infinite distane * Minor aesthetic tweaks to DirectConnectScreen * Cleanup some, but not all, VS project files

* Added missing mob .cpp files to CMakeLists.txt * Cleaned up Visual Studio project files * Fixed SDL2 client building for Windows on VS * Fixed mouse centering on SDL2 clients

platforms/sdl/base/AppPlatform_sdl_base.cpp

platforms/sdl/desktop/AppPlatform_sdl.cpp

source/client/gui/Screen.cpp

* Added ChunkPos * Added Vec2 * Added Facing::Name enum for cardinal directions * Added TilePos (this is a must-see!) * Added ChunkTilePos Cleaned up input handling * Added SDL2 controller support * Added read-only "Use Controller" "option" to visualize current input handler * Created ControllerBuildInput & ControllerMoveInput * Moved mouse-specific build-input-handling code from Minecraft class to new MouseBuildInput class * Refactored BuildActionIntention Cleaned up VS project files * Fixed VS include path properties * Corrected SDL2 client building in VS Other * Moved iOS-specific assets to accurate location * Abstracted EmptyLevelChunk CPP into its own .cpp file

platforms/sdl/base/AppPlatform_sdl_base.cpp

platforms/windows/projects/LibPNG/LibPNG.vcxproj

source/CMakeLists.txt

iProgramMC · 2024-06-19T14:36:06Z

source/client/app/Minecraft.cpp

+					player->startDestroying();
+				}
+
+				bool contDestory = m_pGameMode->continueDestroyBlock(player, m_hitResult.m_tilePos, m_hitResult.m_hitSide);


typo, also unused variable, why?

I'm not sure what you mean.

iProgramMC · 2024-06-28T15:02:13Z

source/world/level/Explosion.cpp

-			vx = dX / dist;
-			vy = dY / dist;
-			vz = dZ / dist;
+			// what about .normalize()?


True, why not add that

See updated code.

iProgramMC · 2024-06-28T15:07:41Z

source/world/level/Level.cpp

@@ -69,7 +69,7 @@ Level::~Level()

 		//you better HOPE this is freed by Minecraft!
 		//Really should have used shared pointers and stuff.
-		if (!pEnt->isLocalPlayer())
+		//if (!pEnt->isLocalPlayer())


Warning! This hack was added in for a reason -- it's possible that m_pLocalPlayer or m_pMobPersp may have a stale reference after this which would be absolutely terrible

How is that possible? From what I can tell, Level is deconstructed in SavingWorldScreen::tick(), then m_pMobPersp and m_pLocalPlayer are set to nullptr.

Wasn't the case when I added that line. I'll take a look later and see when this happens.

I've changed this to isPlayer, since the NetworkHandlers are typically in charge of freeing the Player pointers in NetworkPlayer. Originally, the server would crash if a player left who had died, since their entity would be removed by the Level but was still present in the NetworkPlayer.

iProgramMC · 2024-06-28T15:09:56Z

source/world/level/Level.cpp

-	int minX = Mth::floor(aabb.min.x),     minY = Mth::floor(aabb.min.y),     minZ = Mth::floor(aabb.min.z),
-		maxX = Mth::floor(aabb.max.x + 1), maxY = Mth::floor(aabb.max.y + 1), maxZ = Mth::floor(aabb.max.z + 1);
+	TilePos min(aabb.min),
+		    max(aabb.max + 1);


+TilePos(1) or +TilePos(1,1,1). Mentioned this before but you should NOT have implicit constructors like that.

source/world/level/Region.cpp

iProgramMC · 2024-06-28T15:23:20Z

source/world/level/TilePos.cpp

+	: x(_x), y(_y < 0 ? 0 : _y), z(_z) {}
+
+TilePos::TilePos(float _x, float _y, float _z)
+	: TilePos((int)floorf(_x), (uint8_t)floorf(_y), (int)floorf(_z)) {}


how about using Mth::floor here

Because Mojang used floorf here. Is there any good reason for me to be using Mth::floor over floorf?

* Added icon for Win32 client * Enabled UI button tab navigation for gamepad * Fixed a couple of incorrect gamepad input mappings * Mitigated LocalPlayer::isImmobile() bug to gamepad only * Tweaked ControllerTurnInput to closer match Legacy Console Edition's turn behavior * Documented various fields * Made timing more percise for Windows

More commits happened

* Fixed networking bugs

* Added normal lighting support * Added the Sun and the Moon * Added entity circle shadows * Added vignette * Added manual mob rendering offset to fix floating mobs

* Fixed glColor3f calls for GLES * Added texture availability check to AppPlatform_iOS * Fixed building via Xcode

* Set iOS deployment target from 6.0 back to 3.0 * Set default GameMode from Survival back to Creative

BrentDaMage · 2024-09-17T03:24:00Z

Adds Controller Support #121 for SDL2.

iProgramMC reviewed Apr 19, 2024

View reviewed changes

GameMods.hpp Outdated Show resolved Hide resolved

iProgramMC reviewed Apr 19, 2024

View reviewed changes

source/client/model/Cube.cpp Show resolved Hide resolved

iProgramMC reviewed Apr 19, 2024

View reviewed changes

source/client/model/ModelPart.cpp Outdated Show resolved Hide resolved

iProgramMC reviewed Apr 19, 2024

View reviewed changes

platforms/sdl/main.cpp Show resolved Hide resolved

BrentDaMage force-pushed the bugfix-cleanup branch from 486cae4 to 98a2079 Compare April 20, 2024 01:54

iProgramMC reviewed Apr 22, 2024

View reviewed changes

source/client/app/Minecraft.hpp Show resolved Hide resolved

source/network/Packet.hpp Outdated Show resolved Hide resolved

source/network/packets/StartGamePacket.cpp Outdated Show resolved Hide resolved

source/world/gamemode/CreativeMode.cpp Outdated Show resolved Hide resolved

BrentDaMage added 11 commits May 4, 2024 21:45

Fixed incomplete "Texture::field_C" to "Texture::m_hasAlpha" rename

44dd588

Bugfixes for Windows SDL2 Visual Studio compilation

faeb113

* It still does not work. I'm not even sure how it broke in the first place.

Added Panorama Toggle

6f6dc66

* Added option & enhancement macro for enabling/disabling the panorama menu background

Partial Network Protocol v3 Support

2331caa

Documentation & More Backporting

77562ff

Minor Additions

e1734d4

* Add EntityType * Add MobFactory * Add PacketUtil * Remove TLong/LongHack remnants * Remove old minecraftcpp.vcxproj file

Fix typo in CMakeLists.txt

80d56f4

Survival Mode Bugfixes

becd1fe

* Reverted protocol version back to 2

Cleanup

e8d83fe

* Added Cow * Made tons of stuff const * Fixed-ish pathfinding

BrentDaMage force-pushed the bugfix-cleanup branch from be9a19d to e8d83fe Compare May 5, 2024 02:47

BrentDaMage added 2 commits May 4, 2024 21:55

Fix un-renamed Texture.m_hasAlpha that loved to hang around for some …

e22ee57

…reason

Fixed minor bugs that gave compile errors :(

7f63d78

iProgramMC reviewed May 5, 2024

View reviewed changes

source/world/entity/MobFactory.hpp Show resolved Hide resolved

source/world/entity/EntityType.hpp Show resolved Hide resolved

BrentDaMage added 5 commits May 6, 2024 18:47

Updated .gitignore for 0.7.0 assets

8fc8a38

* Fixed cloud scroll speed

8ac4093

* Replaced global variable with LevelRenderer::areCloudsAvailable()

macOS & iOS Bugfixes

04ef855

* Added /summon command

b566faf

* Fixed crashing from moving infinite distane * Minor aesthetic tweaks to DirectConnectScreen * Cleanup some, but not all, VS project files

Bugfixes & Cleanup

616ac37

* Added missing mob .cpp files to CMakeLists.txt * Cleaned up Visual Studio project files * Fixed SDL2 client building for Windows on VS * Fixed mouse centering on SDL2 clients

TheBrokenRail reviewed May 13, 2024

View reviewed changes

platforms/sdl/base/AppPlatform_sdl_base.cpp Outdated Show resolved Hide resolved

platforms/sdl/desktop/AppPlatform_sdl.cpp Outdated Show resolved Hide resolved

source/client/gui/Screen.cpp Outdated Show resolved Hide resolved

iProgramMC previously requested changes Jun 28, 2024

View reviewed changes

BrentDaMage added 5 commits July 21, 2024 01:46

Fixed instance of VS rename feature being braindamaged

b7a35aa

* Removed Facing.cpp

a6a9112

Minor fixes in Entity and ControllerMoveInput

01a8608

Fixed Mob travel bug

256d7a4

BrentDaMage and others added 12 commits July 21, 2024 15:18

Remove Facing.cpp from CMakeLists.txt

acca80c

Fix Level::getCubes ambiguous TilePos constructor call

46c83a5

Fixed various bugs & building for macOS + iOS

7656781

Minor compatibility bugfixes

84affa5

Fixed Xcode project settings

c798f79

Additional nullptr #ifndef check

dfa73f8

Documentation + Bug Fixes

411ee02

* Fixed networking bugs

Fixed PR stuff

c725488

Visual Improvements

5a1a99c

* Added normal lighting support * Added the Sun and the Moon * Added entity circle shadows * Added vignette * Added manual mob rendering offset to fix floating mobs

Xcode & Mobile Bugfixes

daabf48

* Fixed glColor3f calls for GLES * Added texture availability check to AppPlatform_iOS * Fixed building via Xcode

Minor Fixes

5b2da61

* Set iOS deployment target from 6.0 back to 3.0 * Set default GameMode from Survival back to Creative

Update CMakeLists.txt

4839ebd

BrentDaMage mentioned this pull request Sep 17, 2024

Controller Support #121

Open

BrentDaMage added 7 commits October 17, 2024 00:38

Merge branch 'master' into bugfix-cleanup

e0b986d

Update TextInputBox.hpp

0d01899

Update Screen.cpp

215f918

Update TextInputBox.hpp

dc63b0d

Update TextInputBox.cpp

5da6f3d

Update TextInputBox.cpp

0ce830d

Update TextInputBox.cpp

6f66cdd

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bugfixes & Cleanup #120

Bugfixes & Cleanup #120

BrentDaMage commented Apr 17, 2024 •

edited

Loading

iProgramMC left a comment •

edited

Loading

BrentDaMage commented Apr 20, 2024

iProgramMC commented Apr 20, 2024

BrentDaMage commented Apr 20, 2024

iProgramMC Jun 19, 2024

BrentDaMage Jul 22, 2024

iProgramMC Jun 28, 2024

BrentDaMage Jul 21, 2024

iProgramMC Jun 28, 2024

BrentDaMage Jul 21, 2024

iProgramMC Jul 21, 2024

BrentDaMage Aug 7, 2024

iProgramMC Jun 28, 2024

iProgramMC Jun 28, 2024

BrentDaMage Jul 21, 2024

BrentDaMage commented Sep 17, 2024 •

edited

Loading

Bugfixes & Cleanup #120

Are you sure you want to change the base?

Bugfixes & Cleanup #120

Conversation

BrentDaMage commented Apr 17, 2024 • edited Loading

iProgramMC left a comment • edited Loading

Choose a reason for hiding this comment

BrentDaMage commented Apr 20, 2024

iProgramMC commented Apr 20, 2024

BrentDaMage commented Apr 20, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

BrentDaMage commented Sep 17, 2024 • edited Loading

BrentDaMage commented Apr 17, 2024 •

edited

Loading

iProgramMC left a comment •

edited

Loading

BrentDaMage commented Sep 17, 2024 •

edited

Loading