ZP/delete endpoint bug fixed #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for watch-next-cyf ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
RbAvci
approved these changes
May 26, 2024
There was a problem hiding this comment.
It works, but i think returning a success JSON is better like here: https://github.com/RbAvci/Full-Stack-Project-Assessment/blob/main/server/api.js#L34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you press delete button, app was not updating immediately. It was updating the videos after refreshing. I found out that the fetch function was actually working but the .then() block before setVideos() function was giving error and causing the app to crash before executing setVideos() function with filtered from deleted video id. Bug fixed according to this issue.