Python: Call graph, meta queries comparing with old call-graph #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RasmusWL
changed the title
RasmusWL
force-pushed
the
call-graph-code
branch
2 times, most recently
from
b56c392 to
64c8f91
Compare
RasmusWL
force-pushed
the
call-graph-pointsto-compare
branch
from
512eb81 to
c15732f
Compare
RasmusWL
force-pushed
the
call-graph-code
branch
2 times, most recently
from
bb104fc to
00ec3a2
Compare
RasmusWL
force-pushed
the
call-graph-pointsto-compare
branch
from
c15732f to
a78ffc1
Compare
RasmusWL
force-pushed
the
call-graph-pointsto-compare
branch
from
a78ffc1 to
3e3416e
Compare
RasmusWL
force-pushed
the
call-graph-pointsto-compare
branch
from
3e3416e to
245155f
Compare
Since meta queries run with DCA only reports difference in alert locations if we want a good comparison between `(call, target)` tuples and `(argument, flow-to-parameter)` tuples, we will need to have working copies for both the old points-to based call graph/argument passing, and the new type tracking based ones. Otherwise we will end up in a situation where call is resolved to target A with points-to, and target B with call-graph, but since it is the same call, DCA will report no difference :| These files should never be merged, but should only exist temporarily while working on the type-tracking based call-graph. I removed copy 2-4 of data-flow/taint-tracking, just to limit duplicate search results.
Also removed referenced to the cached stages... they're not really needed in the copy any longer. (while doing rebase on top of flow summaries, I ended up doing a LOT more changes than before... which I found curious)
and overall overview queries. Relies on points-to dataflow copy
RasmusWL
force-pushed
the
call-graph-pointsto-compare
branch
from
245155f to
f02896d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on the call-graph, I developed queries for comparing against the old dataflow implementation.
This should never be merged, so keeping it as a PR on my own fork.