Python: Support dict.get in type-trackers [WIP]
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to the char-pred of Content, this change should keep exactly the same behavior as before.
This should not result in many changes, since store/load steps are still only implemented for attributes.
While it might be useful to track content to any lookup, it's not something we do right now.
Instead of just relying on the call-graph tests
By using the "simple" variant in the summaries for dictionaries, which should be understood by the type-tracking system. However, it doesn't seem to help much :| Implementation based on: https://github.com/github/codeql/blob/3b1146bf98466a154d647b638d6be301bfe27834/python/ql/test/experimental/dataflow/typetracking-summaries/TestSummaries.qll#L38-L42
Still doesn't fix the `typetracking/content_test.py` test though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.