Merge pull request github#17418 from jketema/throw-inconsistent

C++: Add IR inconsistency test
RasmusWL · Sep 10, 2024 · 90f7b30 · 90f7b30
2 parents 6e0b5bc + dfa1642
commit 90f7b30
Show file tree

Hide file tree

Showing 9 changed files with 49 additions and 0 deletions.
diff --git a/cpp/ql/test/library-tests/ir/ir/PrintAST.expected b/cpp/ql/test/library-tests/ir/ir/PrintAST.expected
@@ -4595,6 +4595,18 @@ ir.c:
 #   76|                 Value = [Literal] 0
 #   76|                 ValueCategory = prvalue
 #   78|     getStmt(1): [ReturnStmt] return ...
+#   80| [TopLevelFunction] void raise_access_violation()
+#   80|   <params>: 
+#   80|   getEntryPoint(): [BlockStmt] { ... }
+#   81|     getStmt(0): [ExprStmt] ExprStmt
+#   81|       getExpr(): [FunctionCall] call to ExRaiseAccessViolation
+#   81|           Type = [VoidType] void
+#   81|           ValueCategory = prvalue
+#   81|         getArgument(0): [Literal] 1
+#   81|             Type = [IntType] int
+#   81|             Value = [Literal] 1
+#   81|             ValueCategory = prvalue
+#   82|     getStmt(1): [ReturnStmt] return ...
 ir.cpp:
 #    1| [TopLevelFunction] void Constants()
 #    1|   <params>: 

diff --git a/cpp/ql/test/library-tests/ir/ir/aliased_ir.expected b/cpp/ql/test/library-tests/ir/ir/aliased_ir.expected
@@ -3250,6 +3250,18 @@ ir.c:
 #   73|     m73_4(unknown)        = ^CallSideEffect                         : ~m70_4
 #   73|     m73_5(unknown)        = Chi                                     : total:m70_4, partial:m73_4
 
+#   80| void raise_access_violation()
+#   80|   Block 0
+#   80|     v80_1(void)           = EnterFunction                           : 
+#   80|     m80_2(unknown)        = AliasedDefinition                       : 
+#   80|     m80_3(unknown)        = InitializeNonLocal                      : 
+#   80|     m80_4(unknown)        = Chi                                     : total:m80_2, partial:m80_3
+#   81|     r81_1(glval<unknown>) = FunctionAddress[ExRaiseAccessViolation] : 
+#   81|     r81_2(int)            = Constant[1]                             : 
+#   81|     v81_3(void)           = Call[ExRaiseAccessViolation]            : func:r81_1, 0:r81_2
+#   81|     m81_4(unknown)        = ^CallSideEffect                         : ~m80_4
+#   81|     m81_5(unknown)        = Chi                                     : total:m80_4, partial:m81_4
+
 ir.cpp:
 #    1| void Constants()
 #    1|   Block 0

diff --git a/cpp/ql/test/library-tests/ir/ir/aliased_ssa_consistency.expected b/cpp/ql/test/library-tests/ir/ir/aliased_ssa_consistency.expected
@@ -8,6 +8,7 @@ sideEffectWithoutPrimary
 instructionWithoutSuccessor
 | ir.c:62:5:62:26 | Chi: call to ExRaiseAccessViolation | Instruction 'Chi: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:57:6:57:30 | void throw_in_try_with_finally() | void throw_in_try_with_finally() |
 | ir.c:73:5:73:26 | Chi: call to ExRaiseAccessViolation | Instruction 'Chi: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:70:6:70:39 | void throw_in_try_with_throw_in_finally() | void throw_in_try_with_throw_in_finally() |
+| ir.c:81:3:81:24 | Chi: call to ExRaiseAccessViolation | Instruction 'Chi: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:80:6:80:27 | void raise_access_violation() | void raise_access_violation() |
 ambiguousSuccessors
 unexplainedLoop
 | ir.c:38:13:38:37 | Constant: 1 | Instruction 'Constant: 1' is part of an unexplained loop in function '$@'. | ir.c:32:6:32:32 | void unexplained_loop_regression() | void unexplained_loop_regression() |

diff --git a/cpp/ql/test/library-tests/ir/ir/aliased_ssa_consistency_unsound.expected b/cpp/ql/test/library-tests/ir/ir/aliased_ssa_consistency_unsound.expected
@@ -8,6 +8,7 @@ sideEffectWithoutPrimary
 instructionWithoutSuccessor
 | ir.c:62:5:62:26 | Chi: call to ExRaiseAccessViolation | Instruction 'Chi: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:57:6:57:30 | void throw_in_try_with_finally() | void throw_in_try_with_finally() |
 | ir.c:73:5:73:26 | Chi: call to ExRaiseAccessViolation | Instruction 'Chi: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:70:6:70:39 | void throw_in_try_with_throw_in_finally() | void throw_in_try_with_throw_in_finally() |
+| ir.c:81:3:81:24 | Chi: call to ExRaiseAccessViolation | Instruction 'Chi: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:80:6:80:27 | void raise_access_violation() | void raise_access_violation() |
 ambiguousSuccessors
 unexplainedLoop
 | ir.c:38:13:38:37 | Constant: 1 | Instruction 'Constant: 1' is part of an unexplained loop in function '$@'. | ir.c:32:6:32:32 | void unexplained_loop_regression() | void unexplained_loop_regression() |

diff --git a/cpp/ql/test/library-tests/ir/ir/ir.c b/cpp/ql/test/library-tests/ir/ir/ir.c
@@ -77,4 +77,8 @@ void throw_in_try_with_throw_in_finally()
   }
 }
 
+void raise_access_violation() {
+  ExRaiseAccessViolation(1);
+}
+
 // semmle-extractor-options: --microsoft
diff --git a/cpp/ql/test/library-tests/ir/ir/raw_consistency.expected b/cpp/ql/test/library-tests/ir/ir/raw_consistency.expected
@@ -9,6 +9,7 @@ instructionWithoutSuccessor
 | ir.c:62:5:62:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:57:6:57:30 | void throw_in_try_with_finally() | void throw_in_try_with_finally() |
 | ir.c:73:5:73:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:70:6:70:39 | void throw_in_try_with_throw_in_finally() | void throw_in_try_with_throw_in_finally() |
 | ir.c:76:5:76:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:70:6:70:39 | void throw_in_try_with_throw_in_finally() | void throw_in_try_with_throw_in_finally() |
+| ir.c:81:3:81:24 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:80:6:80:27 | void raise_access_violation() | void raise_access_violation() |
 ambiguousSuccessors
 unexplainedLoop
 | ir.c:38:13:38:37 | Constant: 1 | Instruction 'Constant: 1' is part of an unexplained loop in function '$@'. | ir.c:32:6:32:32 | void unexplained_loop_regression() | void unexplained_loop_regression() |

diff --git a/cpp/ql/test/library-tests/ir/ir/raw_ir.expected b/cpp/ql/test/library-tests/ir/ir/raw_ir.expected
@@ -3035,6 +3035,22 @@ ir.c:
 #   70|     v70_5(void) = AliasedUse   : ~m?
 #   70|     v70_6(void) = ExitFunction : 
 
+#   80| void raise_access_violation()
+#   80|   Block 0
+#   80|     v80_1(void)           = EnterFunction                           : 
+#   80|     mu80_2(unknown)       = AliasedDefinition                       : 
+#   80|     mu80_3(unknown)       = InitializeNonLocal                      : 
+#   81|     r81_1(glval<unknown>) = FunctionAddress[ExRaiseAccessViolation] : 
+#   81|     r81_2(int)            = Constant[1]                             : 
+#   81|     v81_3(void)           = Call[ExRaiseAccessViolation]            : func:r81_1, 0:r81_2
+#   81|     mu81_4(unknown)       = ^CallSideEffect                         : ~m?
+
+#   82|   Block 1
+#   82|     v82_1(void) = NoOp         : 
+#   80|     v80_4(void) = ReturnVoid   : 
+#   80|     v80_5(void) = AliasedUse   : ~m?
+#   80|     v80_6(void) = ExitFunction : 
+
 ir.cpp:
 #    1| void Constants()
 #    1|   Block 0

diff --git a/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_consistency.expected b/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_consistency.expected
@@ -8,6 +8,7 @@ sideEffectWithoutPrimary
 instructionWithoutSuccessor
 | ir.c:62:5:62:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:57:6:57:30 | void throw_in_try_with_finally() | void throw_in_try_with_finally() |
 | ir.c:73:5:73:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:70:6:70:39 | void throw_in_try_with_throw_in_finally() | void throw_in_try_with_throw_in_finally() |
+| ir.c:81:3:81:24 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:80:6:80:27 | void raise_access_violation() | void raise_access_violation() |
 ambiguousSuccessors
 unexplainedLoop
 | ir.c:38:13:38:37 | Constant: 1 | Instruction 'Constant: 1' is part of an unexplained loop in function '$@'. | ir.c:32:6:32:32 | void unexplained_loop_regression() | void unexplained_loop_regression() |

diff --git a/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_consistency_unsound.expected b/cpp/ql/test/library-tests/ir/ir/unaliased_ssa_consistency_unsound.expected
@@ -8,6 +8,7 @@ sideEffectWithoutPrimary
 instructionWithoutSuccessor
 | ir.c:62:5:62:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:57:6:57:30 | void throw_in_try_with_finally() | void throw_in_try_with_finally() |
 | ir.c:73:5:73:26 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:70:6:70:39 | void throw_in_try_with_throw_in_finally() | void throw_in_try_with_throw_in_finally() |
+| ir.c:81:3:81:24 | CallSideEffect: call to ExRaiseAccessViolation | Instruction 'CallSideEffect: call to ExRaiseAccessViolation' has no successors in function '$@'. | ir.c:80:6:80:27 | void raise_access_violation() | void raise_access_violation() |
 ambiguousSuccessors
 unexplainedLoop
 | ir.c:38:13:38:37 | Constant: 1 | Instruction 'Constant: 1' is part of an unexplained loop in function '$@'. | ir.c:32:6:32:32 | void unexplained_loop_regression() | void unexplained_loop_regression() |