Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow dialogue stack slot from being set in custom actions & mark builtin slots #12917

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Oct 12, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review October 12, 2023 16:50
@ancalita ancalita requested a review from a team as a code owner October 12, 2023 16:50
@ancalita ancalita requested review from a team, Urkem and twerkmeister and removed request for a team October 12, 2023 16:50
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me for now. One thing we have to be careful with: Some built-in slots should be writable. E.g. we have the return_value slot that is there as convenience for setting it in custom actions so that you don't need a new slot for one-off results. Maybe instead of is_builtin it should be is_user_writable. We could have a separate list where we list the writable ones instead of reusing the existing slot lists. Let's keep it in mind for later.

@ancalita
Copy link
Member Author

Some built-in slots should be writable.

I guess it depends on how the new property marker is_builtin will be used in the future. I'll document somewhere that this property captures both writable and read-only builtin slots (perhaps in the slot module).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 3 Security Hotspots
Code Smell A 52 Code Smells

0.0% 0.0% Coverage
0.9% 0.9% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ancalita ancalita merged commit ca0e002 into dm2 Oct 17, 2023
97 checks passed
@ancalita ancalita deleted the ATO-1624-disallow-internal-dialogue-stack-slot-from-being-set-in-custom-actions branch October 17, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants