-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache EndpointConfig
session
#12886
Cache EndpointConfig
session
#12886
Conversation
EndpointConfig
session
|
||
- name: Install ddtrace on Windows | ||
if: needs.changes.outputs.backend == 'true' && matrix.os == 'windows-2019' | ||
run: py -m pip install -U 'ddtrace<2.0.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miraai Is there a unified command provided by Github actions that allows us to install a dependency with a constraint for both OS types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ancalita We can use RUNNER_OS
envar to put this into a single step, your call though if it is worth it
- name: Install ddtrace
if: needs.changes.outputs.backend == 'true'
run: |
if [ "$RUNNER_OS" == "Linux" ]; then
poetry run pip install -U 'ddtrace<2.0.0'
elif [ "$RUNNER_OS" == "Windows" ]; then
py -m pip install -U 'ddtrace<2.0.0'
else
echo "$RUNNER_OS not supported"
exit 1
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is documented here, https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I'm not sure if matrix.os == runner.os
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miraai what approach do you recommend?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 💯
🚀 A preview of the docs have been deployed at the following URL: https://12886--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Proposed changes:
ddtrace
in the CI workflows because the new version2.0.0
released on Tue 3rd Oct upgradeswrapt
to1.15
and uninstalls Tensorflow's constraint to be pinned at<1.15
, this causes 30 job failures.Status (please check what you already did):
black
(please check Readme for instructions)