Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rasa data validate flows #12866

Merged
merged 11 commits into from
Sep 29, 2023
Merged

Implement rasa data validate flows #12866

merged 11 commits into from
Sep 29, 2023

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Sep 25, 2023 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review September 26, 2023 14:56
@ancalita ancalita requested a review from a team as a code owner September 26, 2023 14:56
@ancalita ancalita requested review from a team, Urkem and varunshankar and removed request for a team September 26, 2023 14:57
Urkem
Urkem reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@Urkem Urkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpick comments 💯

rasa/cli/utils.py Outdated Show resolved Hide resolved
rasa/validator.py Show resolved Hide resolved
rasa/validator.py Show resolved Hide resolved
tests/test_validator.py Outdated Show resolved Hide resolved
@ancalita ancalita requested a review from Urkem September 27, 2023 12:53
Urkem
Urkem reviewed Sep 27, 2023
View reviewed changes
rasa/validator.py Outdated Show resolved Hide resolved
rasa/validator.py Show resolved Hide resolved
rasa/cli/utils.py Show resolved Hide resolved
@ancalita ancalita requested a review from Urkem September 28, 2023 16:19
Urkem
Urkem approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@Urkem Urkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@ancalita ancalita merged commit 0179870 into dm2 Sep 29, 2023
98 checks passed
@ancalita ancalita deleted the ATO-1530-add-validation-of-flows-to-rasa-data-validate branch September 29, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Urkem Urkem Urkem approved these changes

@varunshankar varunshankar Awaiting requested review from varunshankar varunshankar was automatically assigned from RasaHQ/engine-squad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ancalita @Urkem