Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure prompts through files - [ENG 510] #12859

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Configure prompts through files - [ENG 510] #12859

merged 8 commits into from
Oct 10, 2023

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Sep 24, 2023 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar requested a review from a team as a code owner September 24, 2023 23:08
@varunshankar varunshankar self-assigned this Sep 24, 2023
@varunshankar varunshankar requested review from tmbo and twerkmeister and removed request for a team September 25, 2023 08:37
twerkmeister
twerkmeister reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Varun, two points:

  • the other components are gonna be taken care of in rasa-plus, right?
  • Could you also add a test for the new functionality for the command generator here

tmbo
tmbo reviewed Oct 6, 2023
View reviewed changes
rasa/shared/utils/llm.py Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12859--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 49 Code Smells

0.0% 0.0% Coverage
1.0% 1.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@varunshankar varunshankar merged commit 503c901 into dm2 Oct 10, 2023
@varunshankar varunshankar deleted the ENG-510-prompts-through-files branch October 10, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

@twerkmeister twerkmeister Awaiting requested review from twerkmeister

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunshankar @tmbo @twerkmeister