Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collect_information scope to reset_after_flow_ends bool property #12854

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Update collect_information scope to reset_after_flow_ends bool property #12854

merged 1 commit into from
Sep 25, 2023

Conversation

ancalita
Copy link
Member

@ancalita ancalita commented Sep 22, 2023 •
edited
Loading

Proposed changes:

  • Fixes ATO-1550
  • In addition, I will prepare a docs PR + a PR to update the bot repo too (although scope wasn't used at all)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@ancalita ancalita marked this pull request as ready for review September 22, 2023 14:57
@ancalita ancalita requested a review from a team as a code owner September 22, 2023 14:57
@ancalita ancalita requested review from tmbo and twerkmeister and removed request for a team September 22, 2023 14:57
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

twerkmeister
twerkmeister approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good 👍

@ancalita ancalita merged commit 4fbb0ea into dm2 Sep 25, 2023
98 checks passed
@ancalita ancalita deleted the ATO-1550-rename-scope-property-of-collect-information-step-to-reset-after-flow-ends-adjust-to-a-boolean-type branch September 25, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twerkmeister twerkmeister twerkmeister approved these changes

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ancalita @tmbo @twerkmeister