Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.7 from Black #12853

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Remove Python 3.7 from Black #12853

merged 2 commits into from
Sep 25, 2023

Conversation

vcidst
Copy link
Contributor

@vcidst vcidst commented Sep 22, 2023

Proposed changes:

  • Remove Python 3.7 formatting from Black

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@vcidst vcidst requested review from tmbo, a team and sanchariGr and removed request for a team September 22, 2023 13:01
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - did you run the formatting? i guess black might format some things differently

@vcidst
Copy link
Contributor Author

vcidst commented Sep 22, 2023

@tmbo Yes, it didn't change anything

❯ make formatter
poetry run black rasa tests
('Configuration file exists at /Users/zi/Library/Application Support/pypoetry, reusing this directory.\n\nConsider moving TOML configuration files to /Users/zi/Library/Application Support/pypoetry, as support for the legacy directory will be removed in an upcoming release.',)
All done! ✨ 🍰 ✨
557 files left unchanged.

@vcidst vcidst enabled auto-merge (squash) September 22, 2023 13:41
@vcidst vcidst merged commit f94ba6d into 3.6.x Sep 25, 2023
95 checks passed
@vcidst vcidst deleted the remove-py37-black branch September 25, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants