Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rasa chat #12836

Merged
merged 5 commits into from
Oct 3, 2023
Merged

Remove rasa chat #12836

merged 5 commits into from
Oct 3, 2023

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Sep 20, 2023

Relates to https://github.com/RasaHQ/rasa-plus/pull/846

Proposed changes:

  • Create a new channel in rasa-plus that extends socketio (e.g. SocketioPro or something like that); this channel is internal for now, no need to add it to built-in channels or to document it. It only extends the blueprint function to add the /chat endpoint – copy the code from OSS there;
  • Move the chat CLI command from OSS repo to rasa-plus repo; update the implementation of the refine_cli hook;
  • Move the /flows endpoint away from the server.py; we will probably need to create a hook for this to work;
  • Update pyproject.toml on OSS to remove this line and on rasa-plus to add it; it makes sure that chat.html is packaged when released;

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb changed the title Ato 1548 remove rasa chat Remove rasa chat Sep 20, 2023
@m-vdb m-vdb force-pushed the ato-1548-remove-rasa-chat branch from 4e0bfae to bde8bf1 Compare September 21, 2023 09:57
@m-vdb m-vdb marked this pull request as ready for review September 21, 2023 15:09
@m-vdb m-vdb requested a review from a team as a code owner September 21, 2023 15:09
@m-vdb m-vdb requested review from ancalita and tmbo and removed request for a team September 21, 2023 15:09
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@m-vdb
Copy link
Collaborator Author

m-vdb commented Sep 25, 2023

@tmbo it looks like we both overlooked the obvious... f9f54bb

@tmbo
Copy link
Member

tmbo commented Sep 25, 2023

lol 😂

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@m-vdb m-vdb merged commit b60ecb4 into dm2 Oct 3, 2023
99 checks passed
@m-vdb m-vdb deleted the ato-1548-remove-rasa-chat branch October 3, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants