Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eng 545 stack cleaning #12834

Merged
merged 21 commits into from
Sep 29, 2023
Merged

Eng 545 stack cleaning #12834

merged 21 commits into from
Sep 29, 2023

Conversation

twerkmeister
Copy link
Contributor

@twerkmeister twerkmeister commented Sep 20, 2023 •
edited
Loading

Proposed changes:

  • minor refactor: made stack frames use kwargs consistently
  • refactor: made tests less reliable on exact label ids but made them refer to the relevant actions instead
  • introduced stack cleaning as part of the command processor

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@twerkmeister twerkmeister requested a review from a team as a code owner September 20, 2023 11:03
@twerkmeister twerkmeister changed the base branch from main to dm2 September 20, 2023 11:03
@twerkmeister twerkmeister changed the title Eng 545 stack cleaning WIP Eng 545 stack cleaning Sep 20, 2023
@twerkmeister twerkmeister changed the title WIP Eng 545 stack cleaning Eng 545 stack cleaning Sep 22, 2023
@twerkmeister twerkmeister requested a review from tmbo September 22, 2023 09:37
tmbo
tmbo approved these changes Sep 27, 2023
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ⭐ 🔥

rasa/dialogue_understanding/patterns/clean_stack.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/patterns/default_flows_for_patterns.yml Outdated Show resolved Hide resolved
rasa/dialogue_understanding/processor/command_processor.py Outdated Show resolved Hide resolved
rasa/dialogue_understanding/processor/command_processor.py Show resolved Hide resolved
rasa/shared/core/flows/flow.py Outdated Show resolved Hide resolved
tests/core/featurizers/test_tracker_featurizer.py Show resolved Hide resolved
rasa/dialogue_understanding/patterns/default_flows_for_patterns.yml Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12834--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@twerkmeister twerkmeister merged commit 6e48abc into dm2 Sep 29, 2023
98 checks passed
@twerkmeister twerkmeister deleted the ENG-545-stack-cleaning branch September 29, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twerkmeister @tmbo