Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eng 542 dm1 banner #12830

Merged
merged 9 commits into from
Sep 20, 2023
Merged

Eng 542 dm1 banner #12830

merged 9 commits into from
Sep 20, 2023

Conversation

m-vdb
Copy link
Collaborator

@m-vdb m-vdb commented Sep 19, 2023

Proposed changes:

  • Cleanup unnecessary files for other banners 39f5176
  • Add new banner
  • Add banner to DM1 pages
Screenshot 2023-09-20 at 09 42 29

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@m-vdb m-vdb marked this pull request as ready for review September 20, 2023 07:43
@m-vdb m-vdb requested a review from amn41 September 20, 2023 07:43
@m-vdb m-vdb changed the base branch from docs-dm2 to eng-540-split-testing-docs September 20, 2023 12:47
@m-vdb m-vdb merged commit 95c2a0e into eng-540-split-testing-docs Sep 20, 2023
@m-vdb m-vdb deleted the eng-542-dm1-banner branch September 20, 2023 12:47
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@github-actions
Copy link
Contributor

🚀 A preview of the docs have been deployed at the following URL: https://12830--rasahq-docs-rasa-v2.netlify.app/docs/rasa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants