Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn if a user has defined a slot named "context" - [ENG 503] #12829

Merged
merged 3 commits into from
Sep 24, 2023
Merged

Warn if a user has defined a slot named "context" - [ENG 503] #12829

merged 3 commits into from
Sep 24, 2023

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Sep 19, 2023 •
edited
Loading

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar requested a review from a team as a code owner September 19, 2023 12:41
@varunshankar varunshankar self-assigned this Sep 19, 2023
@varunshankar varunshankar requested review from tmbo and twerkmeister and removed request for a team September 20, 2023 08:23
twerkmeister
twerkmeister approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@twerkmeister twerkmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just a small suggestion

rasa/model_training.py Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@varunshankar varunshankar merged commit ad3712d into dm2 Sep 24, 2023
98 checks passed
@varunshankar varunshankar deleted the ENG-503-warn-user-when-slot-named-context branch September 24, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twerkmeister twerkmeister twerkmeister approved these changes

@tmbo tmbo Awaiting requested review from tmbo

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunshankar @twerkmeister