add username in RedisLockStore #12822
Conversation
vcidst
requested review from
a team and
Urkem
and removed request for
a team
| @@ -200,6 +200,7 @@ def __init__( | |||
| host: Text = "localhost", | |||
| port: int = 6379, | |||
| db: int = 1, | |||
| username: Optional[Text] = None, | |||
There was a problem hiding this comment.
How is this property extracted from yaml? Double-checking we don't need to do something else there?
There was a problem hiding this comment.
I'm guessing that I'll have to add a line for username in endpoints.yml and it should work. However I'll do a quick test with docker compose and a testbot.
Once that works out I plan to also add unit tests. I didn't think about integration tests yet but if it doesn't take long -- I'll be sure to add that too.
There was a problem hiding this comment.
I'll have to add a line for username in endpoints.yml
Yep, exactly 👍🏻
There was a problem hiding this comment.
@ancalita added an integration test. It doesn't look like unit test will be possible with our given testing setup
|
Closing this PR in favor of #12835 |
|
🚀 A preview of the docs have been deployed at the following URL: https://12822--rasahq-docs-rasa-v2.netlify.app/docs/rasa |
vcidst
deleted the
ATO-1520-add-username-as-a-parameter-for-redis-components
branch
Proposed changes:
usernameto the connection arguments ofRedisLockStoreStatus (please check what you already did):
black(please check Readme for instructions)