Skip to content

Commit

Permalink
Fix 3.6.x build (#13068)
Browse files Browse the repository at this point in the history
* Update poetry install GitHub action

* Store coverage results separately for each os and python version

* Enable CI run on Windows

* Update Gr1N/setup-poetry action

* Use different GitHub actions to install poetry on ubuntu and windows

* Bump GitHub Actions runner OS version to ubuntu-24.04

* Check for Ubuntu 24.04 when installing poetry

* Update ubuntu source index before installing packages necessary for tests

* Update zookeeper and kafka container setup using docker compose

* Disable docs check

* Fix tests code coverage processing

---------

Co-authored-by: Vlada Anicic <[email protected]>
  • Loading branch information
radovanZRasa and rasa-aadlv authored Jan 10, 2025
1 parent d340440 commit 66296b2
Show file tree
Hide file tree
Showing 14 changed files with 136 additions and 113 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/automatic-pr-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
# thats's all. single step is needed - if PR is mergeable according to
# branch protection rules it will be merged automatically
mergepal:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: github.repository == 'RasaHQ/rasa'

steps:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-docs-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
jobs:
changes:
name: Check for file changes
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
docs: ${{ steps.filter.outputs.docs }}
steps:
Expand All @@ -29,9 +29,9 @@ jobs:

test_documentation:
name: Test Documentation
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes]
if: needs.changes.outputs.docs == 'true'
if: needs.changes.outputs.docs == 'true' && false # disabled as docs are moved out in new versions

steps:
- name: Checkout git repository 🕝
Expand Down Expand Up @@ -100,9 +100,9 @@ jobs:

documentation_lint:
name: Documentation Linting Checks
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes]
if: needs.changes.outputs.docs == 'true'
if: needs.changes.outputs.docs == 'true' && false # disabled as docs are moved out in new versions

steps:
- name: Checkout git repository 🕝
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-github-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
test:
name: Run Tests
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
#missing matrix
strategy:
fail-fast: false
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-model-regression-on-schedule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
read_test_configuration:
name: Reads tests configuration
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
matrix_length: ${{ steps.set-matrix.outputs.matrix_length }}
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
deploy_runner_gpu:
name: Deploy Github Runner - GPU
needs: read_test_configuration
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down Expand Up @@ -503,7 +503,7 @@ jobs:

combine_reports:
name: Combine reports
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- model_regression_test_gpu
if: always() && needs.model_regression_test_gpu.result == 'success'
Expand Down Expand Up @@ -542,7 +542,7 @@ jobs:

analyse_performance:
name: Analyse Performance
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: always() && github.event_name == 'schedule'
needs:
- model_regression_test_gpu
Expand Down Expand Up @@ -691,7 +691,7 @@ jobs:
needs:
- deploy_runner_gpu
- model_regression_test_gpu
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci-model-regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
read_test_configuration:
name: Reads tests configuration
if: ${{ github.repository == 'RasaHQ/rasa' && contains(github.event.pull_request.labels.*.name, 'status:model-regression-tests') }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
matrix_length: ${{ steps.set-matrix.outputs.matrix_length }}
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
deploy_runner_gpu:
name: Deploy Github Runner - GPU
needs: read_test_configuration
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: ${{ contains(github.event.pull_request.labels.*.name, 'runner:gpu') && github.repository == 'RasaHQ/rasa' && contains(github.event.pull_request.labels.*.name, 'status:model-regression-tests') && needs.read_test_configuration.outputs.configuration_id != '' }}

steps:
Expand Down Expand Up @@ -492,7 +492,7 @@ jobs:
- read_test_configuration
env:
ACCELERATOR_TYPE: "CPU"
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
max-parallel: 3
matrix: ${{fromJson(needs.read_test_configuration.outputs.matrix)}}
Expand Down Expand Up @@ -733,7 +733,7 @@ jobs:
combine_reports:
name: Combine reports
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- model_regression_test_cpu
- model_regression_test_gpu
Expand Down Expand Up @@ -790,7 +790,7 @@ jobs:

set_job_success_status:
name: Set job success status
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- combine_reports
if: ${{ always() && needs.combine_reports.result == 'success' }}
Expand All @@ -807,7 +807,7 @@ jobs:
add_comment_results:
name: Add a comment with the results
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- combine_reports
if: ${{ always() && needs.combine_reports.result == 'success' }}
Expand Down Expand Up @@ -901,7 +901,7 @@ jobs:
needs:
- deploy_runner_gpu
- model_regression_test_gpu
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: ${{ always() && needs.deploy_runner_gpu.result != 'skipped' && contains(github.event.pull_request.labels.*.name, 'runner:gpu') && contains(github.event.pull_request.labels.*.name, 'status:model-regression-tests') }}

steps:
Expand Down
Loading

0 comments on commit 66296b2

Please sign in to comment.