add tests for default action

RasaHQ · Sep 20, 2023 · 5862afe · 5862afe
1 parent a55303a
commit 5862afe
Show file tree

Hide file tree

Showing 3 changed files with 424 additions and 6 deletions.
diff --git a/rasa/core/actions/action_run_slot_rejections.py b/rasa/core/actions/action_run_slot_rejections.py
@@ -75,9 +75,9 @@ async def run(
             condition = rejection.if_
             utterance = rejection.utter
 
-            rendered_template = Template(condition).render(current_context)
-            predicate = Predicate(rendered_template)
             try:
+                rendered_template = Template(condition).render(current_context)
+                predicate = Predicate(rendered_template)
                 violation = predicate.evaluate(document)
                 structlogger.debug(
                     "collect.predicate.result",
@@ -87,7 +87,7 @@ async def run(
             except (TypeError, Exception) as e:
                 structlogger.error(
                     "collect.predicate.error",
-                    predicate=predicate,
+                    predicate=condition,
                     document=document,
                     error=str(e),
                 )

diff --git a/rasa/shared/core/flows/flow.py b/rasa/shared/core/flows/flow.py
@@ -1000,9 +1000,6 @@ def from_dict(rejection_config: Dict[Text, Any]) -> SlotRejection:
         Returns:
             The parsed slot rejection.
         """
-        structlogger.debug(
-            "flow.slot_rejection.from_dict", rejection_config=rejection_config
-        )
         return SlotRejection(
             if_=rejection_config.get("if"),
             utter=rejection_config.get("utter"),