Skip to content

Commit

Permalink
Bump GitHub Actions runner OS version to ubuntu-24.04
Browse files Browse the repository at this point in the history
  • Loading branch information
rasa-aadlv committed Dec 19, 2024
1 parent d340440 commit 4e61295
Show file tree
Hide file tree
Showing 13 changed files with 54 additions and 54 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/automatic-pr-update.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
# thats's all. single step is needed - if PR is mergeable according to
# branch protection rules it will be merged automatically
mergepal:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: github.repository == 'RasaHQ/rasa'

steps:
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci-docs-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ env:
jobs:
changes:
name: Check for file changes
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
docs: ${{ steps.filter.outputs.docs }}
steps:
Expand All @@ -29,7 +29,7 @@ jobs:

test_documentation:
name: Test Documentation
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes]
if: needs.changes.outputs.docs == 'true'

Expand Down Expand Up @@ -100,7 +100,7 @@ jobs:

documentation_lint:
name: Documentation Linting Checks
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes]
if: needs.changes.outputs.docs == 'true'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-github-actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ env:
jobs:
test:
name: Run Tests
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
#missing matrix
strategy:
fail-fast: false
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci-model-regression-on-schedule.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ env:
jobs:
read_test_configuration:
name: Reads tests configuration
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
matrix_length: ${{ steps.set-matrix.outputs.matrix_length }}
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
deploy_runner_gpu:
name: Deploy Github Runner - GPU
needs: read_test_configuration
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout
Expand Down Expand Up @@ -503,7 +503,7 @@ jobs:

combine_reports:
name: Combine reports
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- model_regression_test_gpu
if: always() && needs.model_regression_test_gpu.result == 'success'
Expand Down Expand Up @@ -542,7 +542,7 @@ jobs:

analyse_performance:
name: Analyse Performance
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: always() && github.event_name == 'schedule'
needs:
- model_regression_test_gpu
Expand Down Expand Up @@ -691,7 +691,7 @@ jobs:
needs:
- deploy_runner_gpu
- model_regression_test_gpu
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:

Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/ci-model-regression.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
read_test_configuration:
name: Reads tests configuration
if: ${{ github.repository == 'RasaHQ/rasa' && contains(github.event.pull_request.labels.*.name, 'status:model-regression-tests') }}
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
matrix_length: ${{ steps.set-matrix.outputs.matrix_length }}
Expand Down Expand Up @@ -158,7 +158,7 @@ jobs:
deploy_runner_gpu:
name: Deploy Github Runner - GPU
needs: read_test_configuration
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: ${{ contains(github.event.pull_request.labels.*.name, 'runner:gpu') && github.repository == 'RasaHQ/rasa' && contains(github.event.pull_request.labels.*.name, 'status:model-regression-tests') && needs.read_test_configuration.outputs.configuration_id != '' }}

steps:
Expand Down Expand Up @@ -492,7 +492,7 @@ jobs:
- read_test_configuration
env:
ACCELERATOR_TYPE: "CPU"
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
strategy:
max-parallel: 3
matrix: ${{fromJson(needs.read_test_configuration.outputs.matrix)}}
Expand Down Expand Up @@ -733,7 +733,7 @@ jobs:
combine_reports:
name: Combine reports
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- model_regression_test_cpu
- model_regression_test_gpu
Expand Down Expand Up @@ -790,7 +790,7 @@ jobs:

set_job_success_status:
name: Set job success status
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- combine_reports
if: ${{ always() && needs.combine_reports.result == 'success' }}
Expand All @@ -807,7 +807,7 @@ jobs:
add_comment_results:
name: Add a comment with the results
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs:
- combine_reports
if: ${{ always() && needs.combine_reports.result == 'success' }}
Expand Down Expand Up @@ -901,7 +901,7 @@ jobs:
needs:
- deploy_runner_gpu
- model_regression_test_gpu
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
if: ${{ always() && needs.deploy_runner_gpu.result != 'skipped' && contains(github.event.pull_request.labels.*.name, 'runner:gpu') && contains(github.event.pull_request.labels.*.name, 'status:model-regression-tests') }}

steps:
Expand Down
44 changes: 22 additions & 22 deletions .github/workflows/continous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ env:
jobs:
changes:
name: Check for file changes
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
# Both of the outputs below are strings but only one exists at any given time
backend: ${{ steps.changed-files.outputs.backend || steps.run-all.outputs.backend }}
Expand Down Expand Up @@ -87,7 +87,7 @@ jobs:
# Runs on pushes to main exclusively
name: Wait for docs tests
if: github.ref_type != 'tag'
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes]

steps:
Expand All @@ -110,7 +110,7 @@ jobs:
quality:
name: Code Quality
if: github.ref_type != 'tag'
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes]

steps:
Expand Down Expand Up @@ -210,7 +210,7 @@ jobs:

changelog:
name: Check for changelog
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

steps:
- name: Checkout git repository 🕝
Expand Down Expand Up @@ -249,7 +249,7 @@ jobs:
- test-full-model-training
- test-other-unit-tests
- test-performance
os: [ubuntu-22.04, windows-2019]
os: [ubuntu-24.04, windows-2019]
python-version: [3.8, 3.9, "3.10"]

steps:
Expand Down Expand Up @@ -323,7 +323,7 @@ jobs:
run: poetry config virtualenvs.in-project true

- name: Install Dependencies (Linux) 📦
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-24.04'
# Poetry intermittently fails to install dependency if it is not PEP 517 compliant
# This is a workaround for that issue
run: |
Expand Down Expand Up @@ -351,7 +351,7 @@ jobs:
make prepare-tests-windows-gha
- name: Add github workflow problem matchers
if: needs.changes.outputs.backend == 'true' && matrix.python-version == 3.7 && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.python-version == 3.7 && matrix.os == 'ubuntu-24.04'
# only annotate based on test runs on ubuntu: otherwise
# all errors will be duplicated for each python / os combination
# therefore, we only enable for the one where most tests are run
Expand All @@ -370,7 +370,7 @@ jobs:
Set-ItemProperty 'HKLM:\System\CurrentControlSet\Control\FileSystem' -Name 'LongPathsEnabled' -value 0
- name: Install ddtrace on Linux
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-24.04'
run: poetry run pip install -U 'ddtrace<2.0.0'

- name: Install ddtrace on Windows
Expand All @@ -395,7 +395,7 @@ jobs:
shell: bash # bash shell is a way to make code run for both Linux and Windows

- name: Store coverage reports
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-24.04'
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 #v4.4.3
with:
name: ${{ matrix.test }}-coverage
Expand All @@ -411,7 +411,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-22.04, windows-2019]
os: [ubuntu-24.04, windows-2019]
python-version: [3.8, 3.9, "3.10"]

steps:
Expand Down Expand Up @@ -478,7 +478,7 @@ jobs:
run: poetry config virtualenvs.in-project true

- name: Install Dependencies (Linux) 📦
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-24.04'
run: |
sudo apt-get -y install libpq-dev
make install-full | tee .output
Expand All @@ -502,7 +502,7 @@ jobs:
make prepare-tests-windows-gha
- name: Add github workflow problem matchers
if: needs.changes.outputs.backend == 'true' && matrix.python-version == 3.7 && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.python-version == 3.7 && matrix.os == 'ubuntu-24.04'
# only annotate based on test runs on ubuntu: otherwise
# all errors will be duplicated for each python / os combination
# therefore, we only enable for the one where most tests are run
Expand All @@ -521,7 +521,7 @@ jobs:
Set-ItemProperty 'HKLM:\System\CurrentControlSet\Control\FileSystem' -Name 'LongPathsEnabled' -value 0
- name: Install ddtrace on Linux
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-24.04'
run: poetry run pip install -U 'ddtrace<2.0.0'

- name: Install ddtrace on Windows
Expand All @@ -546,7 +546,7 @@ jobs:
shell: bash # bash shell is a way to make code run for both Linux and Windows

- name: Store coverage reports
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-22.04'
if: needs.changes.outputs.backend == 'true' && matrix.os == 'ubuntu-24.04'
uses: actions/upload-artifact@b4b15b8c7c6ac21ea08fcf65892d2ee8f75cf882 #v4.4.3
with:
name: ${{ matrix.test }}-coverage
Expand All @@ -556,7 +556,7 @@ jobs:
upload_coverage_reports:
name: Upload coverage reports to codeclimate
if: github.ref_type != 'tag'
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
# Always upload results even if tests failed
needs:
- test
Expand Down Expand Up @@ -608,7 +608,7 @@ jobs:
integration_test:
name: Run Non-Sequential Integration Tests
if: github.ref_type != 'tag'
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
timeout-minutes: 60
needs: [changes]
env:
Expand Down Expand Up @@ -730,7 +730,7 @@ jobs:
broker_integration_test:
name: Run Broker Integration Tests
if: github.ref_type != 'tag'
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
timeout-minutes: 60
needs: [changes]
env:
Expand Down Expand Up @@ -828,7 +828,7 @@ jobs:
sequential_integration_test:
name: Run Sequential Integration Tests
if: github.ref_type != 'tag'
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
timeout-minutes: 60
needs: [changes]
env:
Expand Down Expand Up @@ -926,7 +926,7 @@ jobs:
build_docker_base_images_and_set_env:
name: Build Docker base images and setup environment
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
outputs:
base_image_hash: ${{ steps.check_image.outputs.base_image_hash }}
base_mitie_image_hash: ${{ steps.check_image.outputs.base_mitie_image_hash }}
Expand Down Expand Up @@ -1109,7 +1109,7 @@ jobs:
docker:
name: Build Docker
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
needs: [changes, build_docker_base_images_and_set_env]
env:
IMAGE_TAG: ${{ needs.build_docker_base_images_and_set_env.outputs.image_tag }}
Expand Down Expand Up @@ -1211,7 +1211,7 @@ jobs:

deploy:
name: Deploy to PyPI
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04

# deploy will only be run when there is a tag available
if: github.event_name == 'push' && startsWith(github.ref, 'refs/tags') && github.repository == 'RasaHQ/rasa'
Expand Down Expand Up @@ -1287,7 +1287,7 @@ jobs:

send_slack_notification_for_release_on_failure:
name: Notify Slack & Publish Release Notes
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
# run this job when the workflow is triggered by a tag push
if: always() && github.repository == 'RasaHQ/rasa' && github.ref_type == 'tag'
needs:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/dependabot-batch-updater.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
update_dependencies:
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
name: Update dependencies
steps:
- uses: RasaHQ/dependabot-batch-updater@f049cbb0bbd3754bcb5ab154a79f00cd780fc633 # v1.0
Expand Down
Loading

0 comments on commit 4e61295

Please sign in to comment.