make changes for re-ask continuous loop until valid outcome

rasa/core/actions/evaluate_predicate_rejections_action.py

@@ -48,6 +48,18 @@ async def run(
             return []
 
         slot_name = top_frame.collect_information
+        slot_instance = tracker.slots.get(slot_name)
+        if slot_instance and not slot_instance.has_been_set:
+            # this is the first time the assistant asks for the slot value,
+            # therefore we skip the predicate validation because the slot
+            # value has not been provided
+            structlogger.debug(
+                "first.collect.slot.not.set",
+                slot_name=slot_name,
+                slot_value=slot_instance.value,
+            )
+            return []
+
         slot_value = tracker.get_slot(slot_name)
 
         current_context = dialogue_stack.current_context()
@@ -65,6 +77,7 @@ async def run(
                 result = predicate.evaluate(document)
                 structlogger.debug(
                     "collect.predicate.result",
+                    predicate=predicate.description(),
                     result=result,
                 )
             except (TypeError, Exception) as e:
@@ -79,9 +92,8 @@ async def run(
             if result is False:
                 continue
 
-            if current_context.get("number_of_tries", 0) < 2:
-                # reset slot value that was initially filled with an invalid value
-                events.append(SlotSet(top_frame.collect_information, None))
+            # reset slot value that was initially filled with an invalid value
+            events.append(SlotSet(top_frame.collect_information, None))
 
             if utterance is None:
                 structlogger.debug(

rasa/core/policies/flow_policy.py

@@ -576,14 +576,6 @@ def _run_step(
 
             if action_name in self.domain.action_names_or_texts:
                 structlogger.debug("flow.step.run.action", context=context)
-
-                if step.id == "ask_collect_information":
-                    # increment number of retries to keep track of how many times
-                    # the question has been asked
-                    top_frame = self.dialogue_stack.top()
-                    if isinstance(top_frame, CollectInformationPatternFlowStackFrame):
-                        top_frame.number_of_tries = top_frame.number_of_tries + 1
-
                 return PauseFlowReturnPrediction(ActionPrediction(action_name, 1.0))
             else:
                 structlogger.warning("flow.step.run.action.unknown", action=action_name)
@@ -694,15 +686,12 @@ def trigger_pattern_ask_collect_information(
         collect_information: str,
         rejections: Optional[List[Dict[Text, Any]]],
     ) -> None:
-        context = self.dialogue_stack.current_context().copy()
-        number_of_tries = context.get("number_of_tries", 0)
-
+        """Trigger the pattern to ask for a slot value."""
         slot_value_rejections = rejections if rejections else []
 
         self.dialogue_stack.push(
             CollectInformationPatternFlowStackFrame(
                 collect_information=collect_information,
-                number_of_tries=number_of_tries,
                 rejections=slot_value_rejections,
             )
         )

rasa/dialogue_understanding/patterns/collect_information.py

@@ -20,8 +20,6 @@ class CollectInformationPatternFlowStackFrame(PatternFlowStackFrame):
     collect_information: str = ""
     """The information that should be collected from the user.
     this corresponds to the slot that will be filled."""
-    number_of_tries: int = 0
-    """The number of times the question is being asked to fill the slot."""
     rejections: Optional[List[Dict[str, Any]]] = None
     """The predicate check that should be applied to the collected information.
     If a predicate check fails, its `utter` action indicated under rejections
@@ -47,7 +45,6 @@ def from_dict(data: Dict[str, Any]) -> CollectInformationPatternFlowStackFrame:
             data["frame_id"],
             step_id=data["step_id"],
             collect_information=data["collect_information"],
-            number_of_tries=data.get("number_of_tries", 0),
             rejections=data.get("rejections"),
         )
 

rasa/dialogue_understanding/patterns/default_flows_for_patterns.yml

@@ -110,12 +110,6 @@ flows:
     description: flow used to fill a slot
     steps:
       - id: "start"
-        action: action_extract_slots
-        next:
-          - if: "{{context.collect_information}} is null and {{context.number_of_tries}} < 2"
-            then: "ask_collect_information"
-          - else: "evaluate_predicate_rejections"
-      - id: "evaluate_predicate_rejections"
         action: action_evaluate_predicate_rejections
         next: "validate"
       - id: "validate"