Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating layers while moving map #61

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rphlo
Copy link
Contributor

@rphlo rphlo commented Nov 4, 2024

FIx #43

@Raruto
Copy link
Owner

Raruto commented Nov 25, 2024

Hi @rphlo, I don't have much time to follow this properly right now.

Since you have already sent other PRs in the past, would you like to be added as a repo collaborator?

@rphlo
Copy link
Contributor Author

rphlo commented Nov 26, 2024

It would be a shame to have this repo abandoned, however I also do not have the time to overlook another project, and I do not feel like I have a full understanding of this one either, my contributions so far have been minor.
This PR is tiny, and I hope you will find time to review it at some point so that others can enjoy the improvement it made for me... but I understand if we have to wait a bit.

@Raruto
Copy link
Owner

Raruto commented Nov 26, 2024

Call me weird, but I don't own a touchable device, surely there will be other ways to test such things, but more brains wouldn't hurt..

my contributions so far have been minor.

Yes, for this reason too. I like concise solutions (less reads/tests).

I do not feel like I have a full understanding of this one either

Me niether.. 😄 (though overall I think it's quite stable)

BTW, basic functioning is explained in here: #17 (comment)


My expectations for this plugin are pretty basic..

That's why I would recommend anyone who has a project based on this to join the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rotate mobile device path don't follow
2 participants