Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully handle encryption errors in session #49

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

joelambert
Copy link
Member

What does this implement/fix? Explain your changes.

Enabling encrypted sessions on a site that already has unencrypted sessions would throw an exception. This makes the EncryptedStore handle unexpected data more gracefully.

Does this close any currently open issues?

No

@joelambert joelambert requested a review from adamtomat October 4, 2023 08:21
Copy link
Member

@adamtomat adamtomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@adamtomat adamtomat merged commit e66e6d9 into master Oct 11, 2023
12 checks passed
@joelambert joelambert deleted the gracefully-handle-enabling-encrypted-sessions branch October 13, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants