Use expect exception

Rareloop · Mar 20, 2024 · adf9eff · adf9eff
1 parent 27681e3
commit adf9eff
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/tests/Unit/PostQueryBuilderTest.php b/tests/Unit/PostQueryBuilderTest.php
@@ -51,15 +51,9 @@ public function can_create_a_builder_from_static_functions()
      */
     public function throw_error_on_missing_static_function()
     {
-        $errorThrown = false;
+        $this->expectException(Throwable::class);
 
-        try {
-            Post::missingStaticFunction();
-        } catch (Throwable $e) {
-            $errorThrown = true;
-        }
-
-        $this->assertTrue($errorThrown);
+        Post::missingStaticFunction();
     }
 
     private function assertQueryBuilder($function, $params, $postType)

diff --git a/tests/Unit/ScopedQueryBuilderTest.php b/tests/Unit/ScopedQueryBuilderTest.php
@@ -115,16 +115,10 @@ public function can_pass_params_into_a_query_scope_on_post_object()
      */
     public function missing_query_scope_throws_an_error()
     {
-        $errorThrown = false;
+        $this->expectException(Throwable::class);
 
-        try {
-            $builder = new ScopedQueryBuilder(PostWithQueryScope::class);
-            $builder->nonExistentScope();
-        } catch (Throwable $e) {
-            $errorThrown = true;
-        }
-
-        $this->assertTrue($errorThrown);
+        $builder = new ScopedQueryBuilder(PostWithQueryScope::class);
+        $builder->nonExistentScope();
     }
 
     /** @test */