Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed deadlock when receiving new block during VerifyDB #379

Merged
merged 2 commits into from
May 30, 2024

Conversation

CodeIsTheKey
Copy link
Collaborator

Fixed deadlock that can occur when a block comes in while in VerifyDB at startup.

Improved Update/Vote logging after testing.

@CodeIsTheKey
Copy link
Collaborator Author

This is the situation that occurred:

2024-05-30T00:48:47Z POTENTIAL DEADLOCK DETECTED
2024-05-30T00:48:47Z Previous lock order was:
2024-05-30T00:48:47Z  (2) cs_main init.cpp:2173 (in thread init)
2024-05-30T00:48:47Z  (2) cs_main validation.cpp:4832 (in thread init)
2024-05-30T00:48:47Z  cs evo/deterministicmns.cpp:661 (in thread init)
2024-05-30T00:48:47Z  cs evo/deterministicmns.cpp:975 (in thread init)
2024-05-30T00:48:47Z  (1) updateMutex update/update.cpp:304 (in thread init)
2024-05-30T00:48:47Z Current lock order is:
2024-05-30T00:48:47Z  (1) updateMutex update/update.cpp:304 (in thread loadblk)
2024-05-30T00:48:47Z  (2) cs_main validation.cpp:1052 (in thread loadblk)

Copy link
Collaborator

@npq7721 npq7721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@npq7721 npq7721 merged commit b292eb6 into Raptor3um:develop May 30, 2024
11 checks passed
@CodeIsTheKey CodeIsTheKey deleted the verify_deadlock_fix branch June 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants