Add support for bows #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
RappyTV
requested changes
Aug 1, 2024
| @@ -55,6 +56,7 @@ private void migrateFromOne(ConfigurationVersionUpdateEvent event) { | |||
| pickaxe = config.get("pickaxePercentage").getAsInt(); | |||
| axe = config.get("axePercentage").getAsInt(); | |||
| shovel = config.get("shovelPercentage").getAsInt(); | |||
| bow = config.get("bowPercentage").getAsInt(); | |||
There was a problem hiding this comment.
This needs to be removed as it would throw an exception resulting in every other value not being migrated
Suggested change
| bow = config.get("bowPercentage").getAsInt(); |
Closed
|
Removed the code for the migration. What is the version in build.gradle.kts used for? Just the project version? Sorry, I'm not often working with gradle or java in general. Edit: Figured it out myself by looking at your releases. Bumped the version to 1.4.2. |
|
yea its the labymod addon version ^^ |
RappyTV
approved these changes
Aug 2, 2024
|
it's released on FlintMC now. only thing left is waiting until nico approves it |
|
Alright, great! Now is probably a good time to say thank you for this add-on, it really saved my tools a bunch of times :) |
|
thanks! it means a lot to me 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes my issue opened in #23
Accidentally added bows to migration from config v1, probably shouldn't matter though. If not, I can remove it.