Add storageid and replicationid labels to volumegroupreplication #1691
+11
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elena Gershkovich <[email protected]>
rakeshgm
reviewed
Dec 3, 2024
| spec: | ||
| provisioner: rook-ceph.rbd.csi.ceph.com | ||
| parameters: | ||
| replication.storage.openshift.io/replication-secret-name: rook-csi-rbd-provisioner | ||
| replication.storage.openshift.io/replication-secret-namespace: rook-ceph | ||
| clusterID: rook-ceph |
There was a problem hiding this comment.
Can you explain what this clusterID means. There is also a ClusterId in PeerClass struct, the id is retrieved from kube-system of the cluster, check here.
There was a problem hiding this comment.
This is not a ceph cluster ID, this is the clusterID which is used to get the ceph mon and other details. we have same in storageclass and volumegroupsnapshot class as well.
|
Apart from the clarification requested above, the labelling with SID, RID on VGRC looks fine to me. |
rakeshgm
approved these changes
Dec 3, 2024
ELENAGER
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of peer classes update, I added two mandatory labels to volume group replication:
Also
clusterID: rook-ceph
pool: $pool
During the integration process, we found out, that these parameters have to be added to volume group replication. This adjustment is necessary to meet CSI requirements