e2e: replace kubernetes.Clientset with client.Client #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raghavendra-talur
force-pushed
the
rtalur-remove-clientset-client
branch
2 times, most recently
from
0b5116e to
1e52a3e
Compare
Just simplifying the code a bit more. We were using kubernetes.Clientset for things where we couldn't figure out how to use client.Client. Signed-off-by: Raghavendra Talur <[email protected]>
as that is the only Client we have in the cluster context now. To avoid shadowing of the client package from controller-runtime, the package import name is changed to CtrlClient now. Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-remove-clientset-client
branch
from
1e52a3e to
51d05ba
Compare
nirs
approved these changes
Dec 5, 2024
| @@ -11,7 +11,7 @@ import ( | |||
| "k8s.io/apimachinery/pkg/runtime" | |||
| "k8s.io/client-go/tools/clientcmd" | |||
| "k8s.io/kubectl/pkg/scheme" | |||
| "sigs.k8s.io/controller-runtime/pkg/client" | |||
| ctrlClient "sigs.k8s.io/controller-runtime/pkg/client" | |||
There was a problem hiding this comment.
Do we really need to rename? Client field does not clash with client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just simplifying the code a bit more. We were using kubernetes.Clientset for things where we couldn't figure out how to use client.Client.