[WIP] Enhancements for DRClusterConfig
#1637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raaizik
force-pushed
the
1636-ra
branch
2 times, most recently
from
8fc0b7c to
f727104
Compare
| @@ -62,6 +65,14 @@ spec: | |||
| type: object | |||
There was a problem hiding this comment.
@raaizik This is where the discrepancy is. I am wondering why the make generate output is different for you and the CI.
Most likely a version difference in controller-gen.
raaizik
force-pushed
the
1636-ra
branch
3 times, most recently
from
373464f to
8033fe0
Compare
ClusterID is required field that's also immutable Signed-off-by: raaizik <[email protected]>
Adds a basic status to DRClusterConfig reflecting success or failure of reconciliation Signed-off-by: raaizik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ClusterIDas it's a required and immutable fieldResolves issue #1636