Skip to content

Commit

Permalink
Fix typo in progression constant
Browse files Browse the repository at this point in the history
Rename ProgressionCheckingFailoverPrequisites to ProgressionCheckingFailoverPrerequisites
and update the progress message. This may break users hard-coding the
progression text.

Signed-off-by: Nir Soffer <[email protected]>
  • Loading branch information
nirs authored and ShyamsundarR committed Dec 4, 2024
1 parent ea2c157 commit e6f22e5
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion api/v1alpha1/drplacementcontrol_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ const (
ProgressionWaitForReadiness = ProgressionStatus("WaitForReadiness")
ProgressionCleaningUp = ProgressionStatus("Cleaning Up")
ProgressionWaitOnUserToCleanUp = ProgressionStatus("WaitOnUserToCleanUp")
ProgressionCheckingFailoverPrequisites = ProgressionStatus("CheckingFailoverPrequisites")
ProgressionCheckingFailoverPrerequisites = ProgressionStatus("CheckingFailoverPrerequisites")
ProgressionFailingOverToCluster = ProgressionStatus("FailingOverToCluster")
ProgressionWaitForFencing = ProgressionStatus("WaitForFencing")
ProgressionWaitForStorageMaintenanceActivation = ProgressionStatus("WaitForStorageMaintenanceActivation")
Expand Down
4 changes: 2 additions & 2 deletions internal/controller/drplacementcontrol.go
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ func (d *DRPCInstance) switchToFailoverCluster() (bool, error) {
addOrUpdateCondition(&d.instance.Status.Conditions, rmn.ConditionPeerReady, d.instance.Generation,
metav1.ConditionFalse, rmn.ReasonNotStarted,
fmt.Sprintf("Started failover to cluster %q", d.instance.Spec.FailoverCluster))
d.setProgression(rmn.ProgressionCheckingFailoverPrequisites)
d.setProgression(rmn.ProgressionCheckingFailoverPrerequisites)

curHomeCluster := d.getCurrentHomeClusterName(d.instance.Spec.FailoverCluster, d.drClusters)
if curHomeCluster == "" {
Expand Down Expand Up @@ -2240,7 +2240,7 @@ failoverProgressions are used to indicate progression during failover action pro
- postFailoverProgressions indicates Progressions that are noted post creating VRG on the failoverCluster
preFailoverProgressions := {
ProgressionCheckingFailoverPrequisites,
ProgressionCheckingFailoverPrerequisites,
ProgressionWaitForFencing,
ProgressionWaitForStorageMaintenanceActivation,
}
Expand Down

0 comments on commit e6f22e5

Please sign in to comment.