-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a basic GUI to Hypermine powered by yakui #395
Conversation
Draft status: This version currently crashes intermittently when switching materials with a Vulkan validation error. Based on my own testing, I believe that this can be resolved when SecondHalfGames/yakui#155 is merged, and this PR points to the new branch. See comment thread of #391 for details. Otherwise, I think it's ready for review. EDIT: Now that the PR has been merged, I'll upgrade this to a regular PR, although I am aware that some changes will still be needed. Thanks for reviewing! |
While testing this, I encountered a (potentially rare) warning log after I closed the application saying the following: This seems to be a log from My EDIT: Now that Quinn has been upgraded, this comment is likely irrelevant now. Thanks for upgrading it! |
d51146a
to
475583a
Compare
I had renamed the I expect this code might see a fair bit of churn in future PRs just due to the uncertainty of how all the UI elements will work together. |
I don't think we changed anything that would be relevant to that error, FWIW. Sounds like something called |
This PR adds a GUI with the following features: