Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winit now defaults to raw-window-handle 0.6, but ash-window is not yet compatible with this version of raw-window-handle. Fortunately, the
rwh_05
feature allows the use of the older version of raw-window-handle.A few notable changes:
virtual_keycode
had to be replaced withphysical_key
orlogical_key
. I guessed thatphysical_key
was better.Event::MainEventsCleared
was removed from winit, so I needed to switch toAboutToWait
. However, I used https://github.com/rust-windowing/winit/blob/7bed5eecfdcbde16e5619fd137f0229e8e7e8ed4/examples/request_redraw.rs as an example, which had me make the additional change of putting all the frame logic inWindowEvent::RedrawRequested
and usingself.window.request_redraw
inEvent::AboutToWait
. I'm not certain this is what we want for Hypermine, but I didn't notice any issues on my end when testing it.(I meant to re-open #325, but GitHub disallowed it. If it still has problems, I might leave this PR open as a draft instead of closing it.)
EDIT: It looks like all CI checks have passed this time. This PR should be ready to review.