Delay client Sim creation until server parameters are received #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patowen
force-pushed
the
delay-client-sim-creation
branch
from
60330e1
to
801274b
Compare
Ralith
approved these changes
Oct 23, 2023
This allows Sim to store SimConfig without wrapping it in an Option
patowen
force-pushed
the
delay-client-sim-creation
branch
from
801274b
to
7951e98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the client's
Simto store aSimConfigwithout wrapping it in anOption. The main downside is that it slightly complicateswindow.rsanddraw.rs, but such complication is likely temporary and would go away in a future refactor (such as if a "connecting" screen is created, diverting control flow earlier pre-ServerHello).