Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added translation into Uzbek #1998

Merged
merged 10 commits into from
Nov 20, 2024
Merged

Conversation

alishersuyunov
Copy link
Contributor

No description provided.

@ia ia added the Translations Linguas, i18n & l10. label Nov 19, 2024
@ia ia self-assigned this Nov 19, 2024
@ia
Copy link
Collaborator

ia commented Nov 19, 2024

Hello. Are you going to keep working on it? If yes, then I will try to help you with anything I can, if you don't mind. And you shouldn't drop it only because it failed to build from the first attempt.

So, these are first few recommendations:

  • merge the most recent updates from dev branch with your forked branch to keep your changes up to date;
  • your version of translation_UZ.json misses a lot of required strings to make build successful (it's like missing declarations of variables used in the code itself);
  • your version of translation_UZ.json is out of style with other translation_LANG: please, keep in mind that it's essential to keep code style (such as indents with spaces and/or tabs depending on a file) exactly in the same way as code/files around (it's more easier then to check changes, review patches, trace and debug issues).

If you don't mind and if I will be having free time, then I will try to help you with all of that. :)

@ia
Copy link
Collaborator

ia commented Nov 19, 2024

I synced your forked branch. Don't worry - it's possible because your branch uzbek-lang-added from this forked Ralim/IronOS repo is not set as "protected", therefore other contributors can make collaborative commits.

@ia ia requested review from Ralim and discip November 19, 2024 16:43
@ia ia added the Awaiting Response Waiting for user response, if none issue will be closed. label Nov 19, 2024
@ia
Copy link
Collaborator

ia commented Nov 19, 2024

So now translation_UZ.json looks like it should from the start. Dear @alishersuyunov, now you just should translate the rest what's left from English without touching any formatting. Thanks.

Meanwhile, we have a problem here... there is one particular Unicode symbol which is not in the table to display on screen: .

Dear @Ralim & @discip, how do we add a new symbol? I've never done this before nor witnessed it.

To save your time of digging into logs:

  File "/__w/IronOS/IronOS/source/../Translations/make_translation.py", line 546, in get_font_map_per_font
    raise KeyError(f"Symbol |{sym}| is missing in small font set")
KeyError: 'Symbol |‘| is missing in small font set'
make: *** [Makefile:551: Core/Gen/Translation.UZ.cpp] Error 1
make: *** Waiting for unfinished jobs....

@ia
Copy link
Collaborator

ia commented Nov 19, 2024

@alishersuyunov, would it be appropriate to replace UTF symbol that you use () by ASCII apostrophe sign `, what do you think?

@discip
Copy link
Collaborator

discip commented Nov 19, 2024

As far as I know, only the set of characters contained in font_tables.py is used.
I also never witnessed that a character was added.
In the past I copied the character that matched most from font_tables.py.

This should work 😊
@discip discip enabled auto-merge (squash) November 20, 2024 22:26
@discip discip merged commit c86ed08 into Ralim:dev Nov 20, 2024
18 checks passed
discip added a commit that referenced this pull request Nov 20, 2024
discip added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Response Waiting for user response, if none issue will be closed. Translations Linguas, i18n & l10.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants