Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Leap Year Calculator #936

Merged
merged 11 commits into from
Jun 1, 2024
Merged

Conversation

GnanariddhikaRavikumar
Copy link
Contributor

@GnanariddhikaRavikumar GnanariddhikaRavikumar commented May 28, 2024

Fixes Issue🛠️

Closes #847

Description👨‍💻

Adding Leap Year calculator- Leap Year, people says that it comes once in 4 years but there are some exceptional cases, where leap year doesn't occur like in same pattern. For eg: 1896 is a leap year but after 4 years 1900 is not a leap year. To perform or check this I have added a new calculator called Leap Year Calculator. In this if we enter a year it will say whether it as Leapyear or not. It is applicable for all present, past and future.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

I have taken a list of years which may or may not be a leap year and checked . It is working correctly

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

image

LeapYear.mp4

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GnanariddhikaRavikumar, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 28, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit cb0e2a7
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/665b4cc5bbfcf30008482f0f
😎 Deploy Preview https://deploy-preview-936--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 closed this May 31, 2024
@Rakesh9100 Rakesh9100 reopened this May 31, 2024
@Rakesh9100
Copy link
Owner

Pls change the background as text is not visible clearly, enhance the UI and also add Readme file of your calculator in your folder @GnanariddhikaRavikumar

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 31, 2024
@GnanariddhikaRavikumar
Copy link
Contributor Author

@Rakesh9100 I will change it soon.

@Rakesh9100
Copy link
Owner

Enhance the UI slightly with some text and background colors @GnanariddhikaRavikumar

@GnanariddhikaRavikumar
Copy link
Contributor Author

Sure @Rakesh9100

@GnanariddhikaRavikumar
Copy link
Contributor Author

@Rakesh9100 I have altered the UI.

@Rakesh9100 Rakesh9100 merged commit 3d9595c into Rakesh9100:main Jun 1, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳🎉 @GnanariddhikaRavikumar

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task and removed question 🤔 Further information is requested labels Jun 1, 2024
@GnanariddhikaRavikumar
Copy link
Contributor Author

Thank You @Rakesh9100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level3 Advanced task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Leap Year Calculator
2 participants