Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the calculation in CGPA Percentage Calculator #914

Merged
merged 2 commits into from
May 27, 2024

Conversation

nehashekhawat255
Copy link
Contributor

@nehashekhawat255 nehashekhawat255 commented May 27, 2024

Fixes Issue🛠️

Closes #819

Description👨‍💻

I have corrected the formulas in CGPA Percentage Calculator and also updated the readme file for the same.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

I have tested it by giving many inputs in the columns of CGPA and percentage both, and now it is functioning well.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @nehashekhawat255, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 27, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit a38bc66
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/6654b57ac8d65f000801c3d6
😎 Deploy Preview https://deploy-preview-914--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100 Rakesh9100 merged commit 16a8005 into Rakesh9100:main May 27, 2024
5 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🎉 @nehashekhawat255

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Correct the calculation in CGPA Percentage Calculator
2 participants