Fixed negative inputs in Antilog Calculator #912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Aarzookhunger, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Rakesh9100
changed the title
|
Merged 🎉 @Aarzookhunger |
Rakesh9100
added
Completed 🥳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue🛠️
Closes #861
Description👨💻
The base input while calculating the Antilog should be positive and not 1. This issue has been fixed by inculcating the necessary changes in index.html file in the input tag and using validateBaseInput function.
Also the number whose Antilog is being calculated should be positive which has been fixed on the similar lines by making changes in the input tag.
For more detailed information, review the changes made section.
The UI has also been improved.!
Type of change📄
How this has been tested✅
I've checked the code by running it on my system. Screenshot for the same has been attached.
Checklist✅
Screenshots/GIF📷