Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Roman Numeral Calculator #855

Merged
merged 7 commits into from
May 25, 2024

Conversation

sweta-singh28
Copy link
Contributor

@sweta-singh28 sweta-singh28 commented May 24, 2024

Fixes Issue🛠️

Closes #810

Description👨‍💻

Added a new folder called Roman-Numeral-Calculator in the Calculators folder
Added a new box linking to my calculator in the index.html file.

Type of change📄

  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested on all the values within range.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

Screenshot

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @sweta-singh28, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented May 24, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit a04c2c7
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66522b9e77dfe300083cf769
😎 Deploy Preview https://deploy-preview-855--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sweta-singh28 sweta-singh28 marked this pull request as ready for review May 24, 2024 17:05
@Rakesh9100 Rakesh9100 changed the title adding the Roman Numeral Calculator Added Roman Numeral Calculator May 24, 2024
@Rakesh9100
Copy link
Owner

Please style and enhance the UI @sweta-singh28

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label May 24, 2024
@Rakesh9100 Rakesh9100 merged commit 74a54f0 into Rakesh9100:main May 25, 2024
4 checks passed
@Rakesh9100
Copy link
Owner

Congrats on getting your PR merged to the repo under GSSOC 2k24 🥳 @sweta-singh28

@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task and removed question 🤔 Further information is requested labels May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level2 Intermediate task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Roman Numeral Calculator
2 participants