Fixed the null message input in contact form #818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calcdiverse ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @sanyaP19, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨
Rakesh9100
changed the title
|
Netlify manages the submissions and ensures that the form isn't submitted until all fields are filled. I missed this and assigned the issue unnecessarily. No need for the PR to disable the button. Please create and focus on other issues @sanyaP19 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue🛠️
Closes #781
Description👨💻
I have fixed this issue, here, if the message input field is NULL then the submit button gets disabled. When its value gets updated, the button gets enabled again.
Added no cursor feature when the button is disabled and lightened background color of the button when disabled.
Type of change📄
How this has been tested✅
I tested this bug by adding and removing data from the message input field and checking if the message is being sent or not and the button is disabled or not if there is no data in the message field.
Checklist✅
Screenshots/GIF📷